Various fixes #7054

mandy-chessell · 2022-10-27T11:20:05Z

Description

This PR includes various fixes needed to get the new development team open metadata labs working - plus requests for small changes. These are described in the associated issues.

In addition:

I have filled out the swagger @operation tag for each REST operation on Asset Consumer OMAS and created a postman collection for this interface.
I have coded the backend support to allow the connected access services supporting the OCF to be able to retrieve event and API schemas. I have not tested the Java client-side.

Related Issue(s)

Testing

FVT and the labs

Release Notes & Documentation

Just bug fixes

Additional notes

Signed-off-by: Mandy Chessell <mandy.e.chessell@gmail.com>

sonatype-lift · 2022-10-27T13:13:03Z

.../odpi/openmetadata/commonservices/ocf/metadatamanagement/server/OCFMetadataRESTServices.java

+        final String apiOpGUIDParameterName = "apiOperation.getGUID()";
+        final String schemaTypeGUIDParameterName = "apiParameterList.getGUID()";
+
+        Date effectiveTime = new Date();


JavaUtilDate: Date has a bad API that leads to bugs; prefer java.time.Instant or LocalDate.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-27T13:13:04Z

...g/odpi/openmetadata/commonservices/ocf/metadatamanagement/client/ConnectedAPIOperations.java

+            restExceptionHandler.detectAndThrowPropertyServerException(restResult);
+
+            List<APIOperationResponse> apiOperations = restResult.getList();
+            if ((apiOperations == null) || (apiOperations.isEmpty()))


UnnecessaryParentheses: These grouping parentheses are unnecessary; it is unlikely the code will be misinterpreted without them

Suggested change

if ((apiOperations == null) || (apiOperations.isEmpty()))

if ((apiOperations == null) || apiOperations.isEmpty())

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-27T13:13:06Z

...ava/org/odpi/openmetadata/accessservices/datamanager/converters/DatabaseColumnConverter.java

+                    {
+                        for (Relationship relationship : schemaAttributeRelationships)
+                        {
+                            if (repositoryHelper.isTypeOf(serviceName, relationship.getType().getTypeDefName(), OpenMetadataAPIMapper.FOREIGN_KEY_RELATIONSHIP_TYPE_NAME))


NULL_DEREFERENCE: object returned by relationship.getType() could be null and is dereferenced at line 127.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-27T13:13:07Z

...rs/src/main/java/org/odpi/openmetadata/commonservices/generichandlers/SchemaTypeHandler.java

+        {
+            List<EntityDetail> schemaTypeEntities;
+
+            if (repositoryHelper.isTypeOf(serviceName, parentEntity.getType().getTypeDefName(), OpenMetadataAPIMapper.API_SCHEMA_TYPE_TYPE_NAME))


NULL_DEREFERENCE: object returned by parentEntity.getType() could be null and is dereferenced at line 1393.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-27T13:13:09Z

...openmetadata/commonservices/ocf/metadatamanagement/client/ConnectedDeployedAPIOperation.java

+
+        if (requestAttributeCount > 0)
+        {
+            super.headerAttributes = new ConnectedSchemaAttributes(serviceName,


💬 3 similar findings have been found in this PR

ArgumentSelectionDefectChecker: The following arguments may have been swapped: 'maxCacheSize' for formal parameter 'totalElementCount', 'requestAttributeCount' for formal parameter 'maxCacheSize'. Either add clarifying /* paramName= */ comments, or swap the arguments if that is what was intended

Suggested change

super.headerAttributes = new ConnectedSchemaAttributes(serviceName,

requestAttributeCount,

🔎 Expand here to view all instances of this finding

File Path Line Number

open-metadata-implementation/common-services/ocf-metadata-management/ocf-metadata-client/src/main/java/org/odpi/openmetadata/commonservices/ocf/metadatamanagement/client/ConnectedDeployedAPIOperation.java 65

open-metadata-implementation/common-services/ocf-metadata-management/ocf-metadata-client/src/main/java/org/odpi/openmetadata/commonservices/ocf/metadatamanagement/client/ConnectedDeployedAPISchemaType.java 36

open-metadata-implementation/common-services/ocf-metadata-management/ocf-metadata-client/src/main/java/org/odpi/openmetadata/commonservices/ocf/metadatamanagement/client/ConnectedDeployedAPIOperation.java 39

Visit the Lift Web Console to find more details in your report.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-27T13:14:32Z

⚠️ 112 God Classes were detected by Lift in this project. Visit the Lift web console for more details.

mandy-chessell added 17 commits October 27, 2022 09:57

Fix Javadoc

d7dfcf1

Signed-off-by: Mandy Chessell <mandy.e.chessell@gmail.com>

Add final to adminAPI

e5ce509

Signed-off-by: Mandy Chessell <mandy.e.chessell@gmail.com>

Add support for API schemas

8c593d8

Signed-off-by: Mandy Chessell <mandy.e.chessell@gmail.com>

Add support for API schemas

6090038

Signed-off-by: Mandy Chessell <mandy.e.chessell@gmail.com>

Add postman collection

5d17101

Signed-off-by: Mandy Chessell <mandy.e.chessell@gmail.com>

Fill out primary and foreign keys (odpi#7052)

e5e941c

Signed-off-by: Mandy Chessell <mandy.e.chessell@gmail.com>

Update simple catalogs to be REPOSITORY_BACKUPs

faffa64

Signed-off-by: Mandy Chessell <mandy.e.chessell@gmail.com>

Check referene copy headers on delete (odpi#6627)

e33c39f

Signed-off-by: Mandy Chessell <mandy.e.chessell@gmail.com>

Provide access to eventBrokerGUID (odpi#6840)

4a2870e

Signed-off-by: Mandy Chessell <mandy.e.chessell@gmail.com>

Tolerate duplicate anchors classifications (odpi#7051)

3c92b33

Signed-off-by: Mandy Chessell <mandy.e.chessell@gmail.com>

New helpers for enterprise connector (odpi#7051)

295a0f5

Signed-off-by: Mandy Chessell <mandy.e.chessell@gmail.com>

Add swagger tags

c5c71c6

Signed-off-by: Mandy Chessell <mandy.e.chessell@gmail.com>

Fix attached entity's type (odpi#7050)

76e5d87

Signed-off-by: Mandy Chessell <mandy.e.chessell@gmail.com>

Support loading of REPOSITORY BACKUPs through events

e830b93

Signed-off-by: Mandy Chessell <mandy.e.chessell@gmail.com>

Support API and event schemas in OCF

01567b1

Signed-off-by: Mandy Chessell <mandy.e.chessell@gmail.com>

Allow local metadata collection id to be overridden

47b2ea8

Signed-off-by: Mandy Chessell <mandy.e.chessell@gmail.com>

Merge branch 'main' of https://github.com/odpi/egeria into egeria-code

599a75b

mandy-chessell merged commit 2da0c36 into odpi:main Oct 27, 2022

sonatype-lift bot reviewed Oct 27, 2022

View reviewed changes

planetf1 mentioned this pull request Nov 2, 2022

Release 3.13 #6988

Closed

31 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Various fixes #7054

Various fixes #7054

mandy-chessell commented Oct 27, 2022

sonatype-lift bot Oct 27, 2022

sonatype-lift bot Oct 27, 2022

sonatype-lift bot Oct 27, 2022

sonatype-lift bot Oct 27, 2022

sonatype-lift bot Oct 27, 2022

sonatype-lift bot commented Oct 27, 2022

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

	if ((apiOperations == null) \|\| (apiOperations.isEmpty()))
	if ((apiOperations == null) \|\| apiOperations.isEmpty())

	super.headerAttributes = new ConnectedSchemaAttributes(serviceName,
	requestAttributeCount,

File Path	Line Number
open-metadata-implementation/common-services/ocf-metadata-management/ocf-metadata-client/src/main/java/org/odpi/openmetadata/commonservices/ocf/metadatamanagement/client/ConnectedDeployedAPIOperation.java	65
open-metadata-implementation/common-services/ocf-metadata-management/ocf-metadata-client/src/main/java/org/odpi/openmetadata/commonservices/ocf/metadatamanagement/client/ConnectedDeployedAPISchemaType.java	36
open-metadata-implementation/common-services/ocf-metadata-management/ocf-metadata-client/src/main/java/org/odpi/openmetadata/commonservices/ocf/metadatamanagement/client/ConnectedDeployedAPIOperation.java	39

Various fixes #7054

Various fixes #7054

Conversation

mandy-chessell commented Oct 27, 2022

Description

Related Issue(s)

Testing

Release Notes & Documentation

Additional notes

sonatype-lift bot Oct 27, 2022

Choose a reason for hiding this comment

sonatype-lift bot Oct 27, 2022

Choose a reason for hiding this comment

sonatype-lift bot Oct 27, 2022

Choose a reason for hiding this comment

sonatype-lift bot Oct 27, 2022

Choose a reason for hiding this comment

sonatype-lift bot Oct 27, 2022

Choose a reason for hiding this comment

sonatype-lift bot commented Oct 27, 2022