Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next Release (planning) #644

Closed
2 tasks
machawk1 opened this issue May 4, 2020 · 15 comments
Closed
2 tasks

Next Release (planning) #644

machawk1 opened this issue May 4, 2020 · 15 comments
Labels

Comments

@machawk1
Copy link
Member

machawk1 commented May 4, 2020

Let's prime for another release of ipwb!

We are currently waiting on an updated release of ipfshttpclient (py module) before doing so (see ipfs-shipyard/py-ipfs-http-client#204) to mitigate the need to reference their master branch (#638) due to some lagging with the latest version of go-ipfs (v0.5.0). We have some other GitHub issues that have been closed (thanks to @anatoly-scherbakov), some unreleased code that has been merged to master, and other contributions that need some further review before being merged.

Target: May 11, 2020

Need to review, revise, and merge: #631/#604, #640

Other tasks:

  • When ipfshttpclient pushes another release, change ipwb to again reference a release version instead of the master branch.
  • Further tickets to target completion? (/cc @ibnesayeed)
@machawk1 machawk1 added the Meta label May 4, 2020
@machawk1 machawk1 pinned this issue May 5, 2020
@machawk1
Copy link
Member Author

It is now May 11, 2020 and no new release from py-ipfs-http-client. I would like to move forward with pushing a release based on an unreleased version of the module as a dependency either from their master or pinned to the latest commit on their master. Any objections, @ibnesayeed?

@ibnesayeed
Copy link
Member

ibnesayeed commented May 11, 2020

I don't have any objections other than the concerns I have already registered earlier in another ticket. That said, if IPFS 0.5 support is critical now then please go ahead, but if we can wait for a few more days, we should!

@machawk1
Copy link
Member Author

@ibnesayeed I believe IPFS 0.5 support is now critical. Let's release then perhaps push another with the above contributions resolved and merged in.

@ibnesayeed
Copy link
Member

Then go for it with the master branch, pinning to a commit hash might have other issues of not being able to fetch it. If we can afford, we may want to release a beta or rc version so people who desperately need IPFS 0.5 support can download it, but otherwise know that this version will eventually be erased later with a more stable and reproducible release.

@ibnesayeed
Copy link
Member

@github-actions run

#! /bin/sh

exec > comment.buffer

LASTTAG=$(git describe --tags --abbrev=0)

echo "## Changes Since Last Release"

echo "### Pull Requests"
git log --format="%s %b" $LASTTAG..@ | grep "Merge pull request" | cut -d' ' -f4,7- | awk '{print "* "$0}'

echo "### Commits"
git log $LASTTAG..@ --oneline | grep -v "Merge pull request" | awk '{print "* "$0}'

echo "### Changed Files"
echo "\`\`\`"
git diff --stat $LASTTAG..@
echo "\`\`\`"

echo "### Contributors"
git log --format="%an: %s" $LASTTAG..@ | grep -v "Merge pull request" | cut -d":" -f1 | tr ' ' '#' | sort | uniq -c | sort -nr | awk '{print "* "$2" ("$1" commits)"}' | tr '#' ' '

@github-actions
Copy link

github-actions bot commented Jun 9, 2020

Changes Since Last Release

Pull Requests

Commits

  • 6f07e3c Install ipwb in the comment runner workflow
  • 77273ae Add a workflow to execute code from issue comments
  • f4fe811 Document the package release process
  • eed5015 Utilize GH Workflow to publish to PyPI
  • 66f7dc7 Drop Py 3.6 support and add 3.8
  • ec0d17a Disable Windows tests
  • df1b9cb Minor label update
  • f3c01d5 Enable Windows tests
  • c7fad37 Utilize automatic daemon booting feature of IPFS Setup
  • 5f60a67 Revert "Add code coverage as an independent workflow"
  • b91817c Add code coverage as an independent workflow
  • 5ab00fb Refactor jobs in separate workflow files
  • 593668e Install pycodestyle in user space and run from there
  • 269cf06 Install standard script locally and run from there
  • 5f9adeb Abstract linting out from matrix jobs
  • d24a607 Avoid duplicate Docker tests for non-external PRs
  • f3b1e57 Avoid duplicate tests for non-external PRs
  • 135369b Change deafult Python version to latest 3.x
  • f643591 Test in Docker container
  • 6f6efac Target latest patchs of the last two IPFS minor versions
  • f9c24c7 Disable Windows from the matrix as it it halting tests
  • e05a69d Remove Python 3.6 from test matrix
  • b3440cc Disable fail-fast in GH Workflow matrix
  • ba254cf Add GH Workflow for cross-platfrom tests
  • 96c30e7 Adjust var name in indexer to appease newest pycodestyle.
  • f54c3b7 Update TravisCI to use go-ipfs 0.5.1
  • 60214d5 Update dockerfile to go-ipfs v0.5.0 per @ibnesayeed
  • 03a46bc Update Travis for testing with go-ipfs v0.5.0
  • 070ef18 Allow long line exception for temp fix for ipfshttpclient master instead of release
  • b2866d3 Add temporary dependency in setup.py
  • 918f088 Temporarily install ipfshttpclient from master branch, fix Issues when using go-ipfs 0.5.0 #638

Changed Files

 .github/workflows/build.yml       | 15 ++++++++++++++
 .github/workflows/comment-run.yml | 32 +++++++++++++++++++++++++++++
 .github/workflows/dist.yml        | 26 +++++++++++++++++++++++
 .github/workflows/lint.yml        | 21 +++++++++++++++++++
 .github/workflows/test.yml        | 43 +++++++++++++++++++++++++++++++++++++++
 .travis.yml                       |  2 +-
 Dockerfile                        |  4 ++--
 ipwb/indexer.py                   |  2 +-
 release-requirements.txt          |  1 -
 release.sh                        | 10 ++++-----
 requirements.txt                  |  2 +-
 setup.py                          |  4 ++--
 12 files changed, 149 insertions(+), 13 deletions(-)

Contributors

  • Sawood Alam (26 commits)
  • Mat Kelly (5 commits)

@oduwsdl oduwsdl deleted a comment from github-actions bot Jun 9, 2020
@oduwsdl oduwsdl deleted a comment from github-actions bot Jun 9, 2020
@oduwsdl oduwsdl deleted a comment from github-actions bot Jun 9, 2020
@machawk1
Copy link
Member Author

The official ipfshttpclient module has yet to push another release to Pypi. I created https://pypi.org/project/ipfshttpclient4ipwb/ based on the current master, as Pypi won't allow direct references. The ipwb references to this dependency need to be updated from ipfshttpclient.

@ibnesayeed
Copy link
Member

@github-actions run

#! /bin/sh

exec > comment.buffer

LASTTAG=v0.2020.04.24.1847

echo "## Changes Since Last Release"

echo "### Pull Requests"
git log --format="%s %b" $LASTTAG..@ | grep "Merge pull request" | cut -d' ' -f4,7- | awk '{print "* "$0}'

echo "### Commits"
git log $LASTTAG..@ --oneline | grep -v "Merge pull request" | awk '{print "* "$0}'

echo "### Changed Files"
echo "\`\`\`"
git diff --stat $LASTTAG..@
echo "\`\`\`"

echo "### Contributors"
git log --format="%an: %s" $LASTTAG..@ | grep -v "Merge pull request" | cut -d":" -f1 | tr ' ' '#' | sort | uniq -c | sort -nr | awk '{print "* "$2" ("$1" commits)"}' | tr '#' ' '

@github-actions
Copy link

Changes Since Last Release

Pull Requests

Commits

  • 73f136f RELEASE: Bump version to 0.2020.06.18.1933
  • d9c08e7 Update ipfshttpclient dependency to ipfshttpclient4ipwb
  • 7aa5e89 Update Python version requirement in README
  • 3222d14 RELEASE: Bump version to 0.2020.06.18.1615
  • 6f07e3c Install ipwb in the comment runner workflow
  • 77273ae Add a workflow to execute code from issue comments
  • f4fe811 Document the package release process
  • eed5015 Utilize GH Workflow to publish to PyPI
  • 66f7dc7 Drop Py 3.6 support and add 3.8
  • ec0d17a Disable Windows tests
  • df1b9cb Minor label update
  • f3c01d5 Enable Windows tests
  • c7fad37 Utilize automatic daemon booting feature of IPFS Setup
  • 5f60a67 Revert "Add code coverage as an independent workflow"
  • b91817c Add code coverage as an independent workflow
  • 5ab00fb Refactor jobs in separate workflow files
  • 593668e Install pycodestyle in user space and run from there
  • 269cf06 Install standard script locally and run from there
  • 5f9adeb Abstract linting out from matrix jobs
  • d24a607 Avoid duplicate Docker tests for non-external PRs
  • f3b1e57 Avoid duplicate tests for non-external PRs
  • 135369b Change deafult Python version to latest 3.x
  • f643591 Test in Docker container
  • 6f6efac Target latest patchs of the last two IPFS minor versions
  • f9c24c7 Disable Windows from the matrix as it it halting tests
  • e05a69d Remove Python 3.6 from test matrix
  • b3440cc Disable fail-fast in GH Workflow matrix
  • ba254cf Add GH Workflow for cross-platfrom tests
  • 96c30e7 Adjust var name in indexer to appease newest pycodestyle.
  • f54c3b7 Update TravisCI to use go-ipfs 0.5.1
  • 60214d5 Update dockerfile to go-ipfs v0.5.0 per @ibnesayeed
  • 03a46bc Update Travis for testing with go-ipfs v0.5.0
  • 070ef18 Allow long line exception for temp fix for ipfshttpclient master instead of release
  • b2866d3 Add temporary dependency in setup.py
  • 918f088 Temporarily install ipfshttpclient from master branch, fix Issues when using go-ipfs 0.5.0 #638

Changed Files

 .github/workflows/build.yml       | 15 ++++++++++++++
 .github/workflows/comment-run.yml | 32 +++++++++++++++++++++++++++++
 .github/workflows/dist.yml        | 26 +++++++++++++++++++++++
 .github/workflows/lint.yml        | 21 +++++++++++++++++++
 .github/workflows/test.yml        | 43 +++++++++++++++++++++++++++++++++++++++
 .travis.yml                       |  2 +-
 Dockerfile                        |  4 ++--
 README.md                         |  2 +-
 ipwb/__init__.py                  |  2 +-
 ipwb/backends.py                  |  6 +++---
 ipwb/indexer.py                   |  6 +++---
 ipwb/replay.py                    |  2 +-
 ipwb/util.py                      |  6 +++---
 release-requirements.txt          |  1 -
 release.sh                        | 10 ++++-----
 requirements.txt                  |  2 +-
 setup.py                          |  4 ++--
 tests/test_backends.py            |  8 ++++----
 18 files changed, 164 insertions(+), 28 deletions(-)

Contributors

  • Sawood Alam (26 commits)
  • Mat Kelly (9 commits)

@machawk1
Copy link
Member Author

Closing this issue, @ibnesayeed, as we mitigated the ipfshttpclient for now. We can make another issue or use a different means (e.g., GH Projects) to track the next release. I am hoping we can get the binsearch (#604) work integrated.

@machawk1 machawk1 unpinned this issue Jun 22, 2020
@ibnesayeed
Copy link
Member

We need to streamline the release process with automated release notes, but we can track that separately.

@machawk1
Copy link
Member Author

@ibnesayeed You are a little more familiar with that auto-generation process (which I would like to see documented), so please create a GitHub issue of what you anticipate being the ideal process and we can work toward that.

@ibnesayeed
Copy link
Member

I am actually waiting for some changes in an upstream GH action (and have provided feedback there). Depending on how things go, I can create workflow files to achieve the goal. Also, I perhaps will create another GH reusable action to aid the release notes process.

@ibnesayeed
Copy link
Member

ibnesayeed commented Jul 6, 2020

@github-actions run

#! /bin/bash

exec > comment.buffer

git log --format="%(trailers:valueonly,key=Co-authored-by)" | awk -F' <' '$0{print $1}'

@oduwsdl oduwsdl deleted a comment from github-actions bot Jul 6, 2020
@oduwsdl oduwsdl deleted a comment from github-actions bot Jul 6, 2020
@oduwsdl oduwsdl deleted a comment from github-actions bot Jul 6, 2020
@github-actions
Copy link

github-actions bot commented Jul 7, 2020

Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Sawood Alam
Mat Kelly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants