Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Py 3.6 support and add 3.8 #653

Merged
merged 1 commit into from
May 18, 2020
Merged

Drop Py 3.6 support and add 3.8 #653

merged 1 commit into from
May 18, 2020

Conversation

ibnesayeed
Copy link
Member

@ibnesayeed ibnesayeed commented May 18, 2020

Hopefully, it will change the metadata on PyPI and close #652.

@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #653 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #653   +/-   ##
=======================================
  Coverage   27.28%   27.28%           
=======================================
  Files           7        7           
  Lines        1246     1246           
  Branches      191      191           
=======================================
  Hits          340      340           
  Misses        881      881           
  Partials       25       25           
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43936d2...66f7dc7. Read the comment docs.

@ibnesayeed ibnesayeed requested a review from machawk1 May 18, 2020 21:50
Copy link
Member

@machawk1 machawk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@machawk1 machawk1 merged commit 4bac5b1 into master May 18, 2020
@machawk1 machawk1 deleted the issue-652 branch May 18, 2020 21:54
@github-actions github-actions bot mentioned this pull request Jun 8, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update PyPI metadata to reflect supported Python versions
2 participants