Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ipfshttpclient dependency to ipfshttpclient4ipwb #662

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Conversation

machawk1
Copy link
Member

This is due to ipfshttpclient not pushing a new release to pypi and ipwb needing to be compatible with newer go-ipfs binaries, which the currently released (to pypi) version of ipfshttpclient is not.

@machawk1 machawk1 requested a review from ibnesayeed June 18, 2020 19:17
@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #662 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #662   +/-   ##
=======================================
  Coverage   27.28%   27.28%           
=======================================
  Files           7        7           
  Lines        1246     1246           
  Branches      191      191           
=======================================
  Hits          340      340           
  Misses        881      881           
  Partials       25       25           
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
ipwb/backends.py 91.48% <100.00%> (ø)
ipwb/indexer.py 50.57% <100.00%> (ø)
ipwb/replay.py 13.94% <100.00%> (ø)
ipwb/util.py 35.21% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3222d14...d9c08e7. Read the comment docs.

Copy link
Member

@ibnesayeed ibnesayeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Though we could have created an alias when importing to avoid unnecessary renaming in the main code body when referencing the module.

@machawk1
Copy link
Member Author

I agree. This is mainly applicable to {test-}backends.py, as the other scripts seem to have aliases in-place. I think the simple change in this PR will make reverting the name easy going forward when ipfshttpclient pushes another release to pypi.

@machawk1 machawk1 merged commit fc9e33a into master Jun 18, 2020
@machawk1 machawk1 deleted the issue-644 branch June 18, 2020 19:29
@github-actions github-actions bot mentioned this pull request Jun 18, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants