prov/util, shm: fix util srx to adhere to peer api (setting msg_size and flags correctly) #10511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The peer srx should return entries with the FI_MSG/FI_TAGGED and FI_RECV flags set The msg_size field in the peer_rx_entry needs to be set in the expected path to the number of bytes allowed to be copied. This is either the size of the message (from the attr->msg_size paramter) or, if the buffer is not large enough to hold the entire message, the size of the buffer. This also fixes setting the message size and flag fields on the unexpected multi receive path. This case is a bit different because it not only has to account for the message size and buffer size, but also for the owner entry's message size and flags Signed-off-by: Alexia Ingerson <alexia.ingerson@intel.com>
The util srx/peer srx should return the entry with the op flags (FI_MSG/FI_TAGGED + FI_RECV) already set. Remove from the shm code Signed-off-by: Alexia Ingerson <alexia.ingerson@intel.com>
|
@shijin-aws @amirshehataornl Any thoughts or concerns? |
shijin-aws
approved these changes
Nov 13, 2024
shijin-aws
reviewed
Nov 13, 2024
|
|
||
| rx_entry->peer_entry.iov[0].iov_base = | ||
| mrecv_entry->peer_entry.iov->iov_base; | ||
| rx_entry->peer_entry.iov->iov_len = |
There was a problem hiding this comment.
It's a bit strange that we use iov[0] for iov_base while iov-> for iov_len. Is it enforced that multi_recv post has to be 1 iov_count?
There was a problem hiding this comment.
Yes, current util code only supports iov_count == 1 for multi_recv. See the assertion in util_generic_mrecv：
assert(flags & FI_MULTI_RECV && iov_count == 1);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix util_srx implementation to properly set msg_size and flags and remove setting in shm