Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prov/util, shm: fix util srx to adhere to peer api (setting msg_size and flags correctly) #10511

Merged
merged 2 commits into from
Nov 13, 2024
Merged

prov/util, shm: fix util srx to adhere to peer api (setting msg_size and flags correctly) #10511

merged 2 commits into from
Nov 13, 2024

Commits on Nov 4, 2024

  1. prov/util: set srx completion flags and msg_len properly 

    The peer srx should return entries with the FI_MSG/FI_TAGGED and
FI_RECV flags set

The msg_size field in the peer_rx_entry needs to be set in the
expected path to the number of bytes allowed to be copied.
This is either the size of the message (from the attr->msg_size
paramter) or, if the buffer is not large enough to hold the entire
message, the size of the buffer.

This also fixes setting the message size and flag fields on the unexpected
multi receive path. This case is a bit different because it not only has to
account for the message size and buffer size, but also for the owner entry's message
size and flags

Signed-off-by: Alexia Ingerson <alexia.ingerson@intel.com>
    @aingerson
    aingerson committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    b7a1309 View commit details
    Browse the repository at this point in the history

  2. prov/shm: cleanup op flags 

    The util srx/peer srx should return the entry with the op flags
(FI_MSG/FI_TAGGED + FI_RECV) already set. Remove from the shm code

Signed-off-by: Alexia Ingerson <alexia.ingerson@intel.com>
    @aingerson
    aingerson committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    1eb59c4 View commit details
    Browse the repository at this point in the history