Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

[okta-angular]: adds child route guard OKTA-283009 #776

Merged
merged 2 commits into from
May 19, 2020

Conversation

aarongranick-okta
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Adding Tests
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the current behavior?

Issue Number: OKTA-283009

What is the new behavior?

Implements canActivateChild on the OktaAuthGuard

Does this PR introduce a breaking change?

  • Yes
  • No

Reviewers

@swiftone
@shuowu

@swiftone
Copy link
Contributor

Same comment as #778 - we should accumulat the changes in a PENDING entry in the CHANGELOG

@aarongranick-okta aarongranick-okta merged commit 42e7186 into master May 19, 2020
@aarongranick-okta aarongranick-okta deleted the ag-angular-can-activate-OKTA-283009 branch May 19, 2020 16:53
@robt1019
Copy link

Hi @aarongranick-okta do you know when this will be available in the okta-angular npm package? https://www.npmjs.com/package/@okta/okta-angular

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants