[okta-angular] Release 3.0.0 #778
Conversation
|
For cumulative changes we should have a PENDING entry in the CHANGELOG, so that nothing gets missed when we push out a version. (I'm assuming the only reason this isn't getting an immediate release is because you have a few of these small changes going out at once) |
aarongranick-okta
force-pushed
the
ag-angular-auth-instance-OKTA-283293
branch
from
ea6551c
to
a2c005e
Compare
aarongranick-okta
force-pushed
the
ag-angular-auth-instance-OKTA-283293
branch
from
055cdbf
to
e291464
Compare
aarongranick-okta
changed the title
update authJS@4.0.0 updates @okta/configuration-validation@1.0.0 updates test app to ng@7 service inherits from okta-auth-js instance
aarongranick-okta
force-pushed
the
ag-angular-auth-instance-OKTA-283293
branch
from
6755c59
to
3a134b2
Compare
| const tokens = res.tokens; | ||
| if (tokens.accessToken) { | ||
| this.oktaAuth.tokenManager.add('accessToken', tokens.accessToken as AccessToken); | ||
| this.tokenManager.add('accessToken', tokens.accessToken as AccessToken); |
There was a problem hiding this comment.
Should we export the token keys from okta-auth-js?
Shuo's other PR makes these keys configurable, which would break this.
There was a problem hiding this comment.
Looks like this PR is only target to auth-js@4.0 instead of v4.1. My change goes into v4.1
There was a problem hiding this comment.
"@okta/okta-auth-js": "^4.0.0",
That includes 4.1, right?
My question about exporting the keys stands, either way.
There was a problem hiding this comment.
I could modify the semver to ~4.0.0 but there should be no breaking changes in 4.1, right?
There was a problem hiding this comment.
@aarongranick-okta Right. I'm not saying you should change anything, I'm saying 4.1 should be free of breaking changes.
|
|
||
| > This library has been tested for compatibility with the following Angular versions: 4, 5, 6, 7, 8, 9 | ||
| > :warning: Angular versions older than 7 may not be fully compatible with all dependencies of this library, due to an older Typescript version. You may be able to workaround this issue by setting `skipLibChecks: true` in your `tsconfig.json` file. |
There was a problem hiding this comment.
Do we want to claim compatibility with all of these older versions?
There was a problem hiding this comment.
This is related to use of the "unknown" type within the typings for auth-js, "unknown" was introduced in Typescript 3.0. Angular 6 uses a 2.x version of Typescript so it complains. I don't think this breaks compatibility, but we might get questions about it.
There was a problem hiding this comment.
I wasn't talking about the details of that particular error, I'm just saying do we want to commit to supporting this set of versions.
There was a problem hiding this comment.
I say let's wait until a user has an issue and see if we can update the docs with a simple workaround. If not, we can drop support. I don't think there are that many angular users who fail to upgrade - they should expect problems if using a very old version mixed with current versions of other modules.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number:
OKTA-283293
OKTA-290952
What is the new behavior?
Exposes the full AuthJS API via class inheritance.
Removes Typescript types for auth-js and configuration-validation
Updates internal test app to NG 7 (for Typescript > 3)
Updates okta-auth-js to 4.0.0 and configuration-validation to 1.0.0
Does this PR introduce a breaking change?
Reviewers
@swiftone
@shuowu