Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dev merge with upstream v0.5.0-beta6 #13

Merged
merged 22 commits into from
Dec 4, 2024

Conversation

Vui-Chee
Copy link

@Vui-Chee Vui-Chee commented Dec 3, 2024

Some nuance(s):

  1. root Dockerfile omits Rust build (following intention in feat: merge upstream form v0.4.0 beta10 #7)
  2. v0.5.0-beta6 ships with updated e2e workflow (with kurtosis-cdk v0.2.24) - lower versions may pull ethpandaops/lighthouse:stable which breaks API causing CI to explode
  3. For e2e test, fork12-pessimistic is disabled as we do not care about its function (ergo ignoring agglayer_prover_sp1_key in the workflow yml)

goran-ethernal and others added 21 commits November 12, 2024 11:39
* feat: unpack and log agglayer errors

* feat: agglayer error unpacking

* fix: lint and UT
- Send certificates after a percentage of epoch
- Require epoch configuration to AggLayer
- Change config of `aggsender` adding: `BlockFinality` and `EpochNotificationPercentage`
* fix: add new error

* fix: ut

* fix: comment
* change to run gha

* better wait for processot

* handle context cancel

* handle context cancel

* add mutex to halt

* add mutex to halt

* better wait

* better mutex for halted

* lint

* fix wait

* fix wait
* fix: aggregating proofs (0xPolygon#191)

* ensure oldAccInputHash is ready

* feat: updata sync lib

* feat: acc input hash sanity check

* feat: check acc input hash -1

* feat: refactor

* feat: refactor

* fix: batch1 acc input hash

* fix: timestamp in input prover

* fix: timestamp in input prover

* fix: timestamp

* feat: remove test

* fix: test

* fix: test

* fix: comments

* fix: comments

* fix: test
- Split FEP and PP e2e tests
- Add PP that check on aggsender database if there are 1 settle certificate
- Add sqlite client to docker
* feat: e2e

* fix: refactor

* fix: comments

* fix: comments
* feat: sqlite aggregator
…xPolygon#192)

- integration `interop_getLatestKnownCertificateHeader` end-point (aggsender and e2e tests)
- Check agglayer and aggsender are on the same page
- Fix wrong DBPath on default config
- Fix colors on script `local_config`
- Changes on config file: new fields `aggsender.MaxRetriesStoreCertificate` and `aggsender.DelayBeetweenRetries`
- Partial solution to bug CDK-603 on PreviousLER (just fix initial case that first cert fails)

---------

Co-authored-by: Goran Rojovic <goran.rojovic@ethernal.tech>
- Issues a long integration: 
- Wrong process of unknown error field `PError` on certificate header
- Fix use of aggsender log (to be able to filter by module)
- Fix a bad condition to show a warning of a reopen certificate
- Improved test for epoch notifier
- Fix certificate on local DB but AggLayer have none certificate (CDK-604)
- Add logs to `synv/evmdownloader.go` to have more information on error: `error calling FilterLogs to eth client: invalid params`
Support `agglayer:0.2.0-rc.15` the responses of ` CertificateHeader` add a new field: `PreviousLocalExitRoot`
- Fixes error calculating  previousLocalExitRoot on new certificate if a certificate is inError

NOTE: **Database incompatibility with previous version!, require to delete it!**
- Avoid to log full certificate because it's too long
- Add logs to `bridgesync` creation
- Reduce log for `l1infotreesync/processor.go:401`  `block 7157878 processed with 0 events` in case of 0 events
---------

Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com>
* Simplify HashMeddler

* fix: TestCertificateHeaderString UT
… certificates in a history table (0xPolygon#208)

- Add new field `retries` to database, that keep the count of times of regenerated the certificate
- The discarded certificates are move (if configuration allow that) to a new table `certificate_info_history`
- Cherry-picked 0xPolygon#202 to fix e2e-test

## Configuration
```
[AggSender]
KeepCertificatesHistory = true
```
---------

Co-authored-by: Léo Vincent <28714795+leovct@users.noreply.github.com>
Co-authored-by: Toni Ramírez <58293609+ToniRamirezM@users.noreply.github.com>
Co-authored-by: Stefan Negovanović <stefan@ethernal.tech>
* tag 'v0.5.0-beta6':
  feat: write on database the number of retries per certificate and the certificates in a history table (0xPolygon#208)
  feat: return an error in case agglayer returns certificate with height lower than in local storage (0xPolygon#209)
  chore: simplify the `HashMeddler` (0xPolygon#205)
  fix: clean proof table on start (0xPolygon#207) (0xPolygon#210)
  feat: improve logs (0xPolygon#204)
  fix: cdk603 error calculating previousLocalExitRoot (0xPolygon#199)
  fix: Integration Bali PP (0xPolygon#198)
  feat: check agglayer certificate and use as initial if db is empty (0xPolygon#192)
  feat: sqlite aggregator (0xPolygon#189)
  feat: BridgeMessage e2e test (0xPolygon#184)
  feat: aggsender e2e (0xPolygon#183)
  fix: aggregating proofs (0xPolygon#191) (0xPolygon#193)
  feat: l1infotreesync can be run as individual component (0xPolygon#188)
  fix: l1infotree flaky test (0xPolygon#182)
  fix: `L1InfoRootIncorrect` error from `agglayer` (0xPolygon#185)
  feat: improve aggsender logs (0xPolygon#186) (0xPolygon#187)
  feat: remove sanity check (0xPolygon#178) (0xPolygon#179)
  refact: GetSequence method (0xPolygon#169)
  feat: epoch notifier (0xPolygon#144)
  feat: unpack and log agglayer errors (0xPolygon#158)
@Vui-Chee Vui-Chee changed the title Dev merge with upstream v0.5.0-beta6 chore: dev merge with upstream v0.5.0-beta6 Dec 3, 2024
docker: omit line copying rust bin

cheat code: no test no fail
@Vui-Chee Vui-Chee force-pushed the vui-chee/basedev-upstream-v0.5.0-beta6 branch from dd1f9a3 to 3ae693c Compare December 3, 2024 11:27
@Vui-Chee Vui-Chee marked this pull request as ready for review December 4, 2024 01:58
@KamiD KamiD merged commit ce66a07 into dev Dec 4, 2024
9 checks passed
@Vui-Chee Vui-Chee deleted the vui-chee/basedev-upstream-v0.5.0-beta6 branch December 4, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants