change eth_getFilterLogs return from nil to empty logs #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #.
What does this PR do?
From user's feedback, we have found that there is a difference between Erigon and xlayer-node when querying events with
eth_eth_getFilterLogsRPC method. When the RPC cannot find the filter ID from user in its own memory, Erigon will return a[]while our xlayer-node will returnnull. Butnullleads to a NullPointerException (NPE) in web3j and thus causes a crash on user's program.This PR changes all
nullreturns into[]empty returns.Reviewers
Main reviewers:
Codeowner reviewers: