Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change eth_getFilterLogs return from nil to empty logs #217

Merged
merged 2 commits into from
Jun 13, 2024
Merged

change eth_getFilterLogs return from nil to empty logs #217

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a886f20
change eth_getFilterLogs return from nil to empty logs
bylingo Jun 4, 2024
511d797
remove go code style on import
bylingo Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions jsonrpc/endpoints_eth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,13 +537,13 @@ func (e *EthEndpoints) GetFilterChanges(filterID string) (interface{}, types.Err
func (e *EthEndpoints) GetFilterLogs(filterID string) (interface{}, types.Error) {
filter, err := e.storage.GetFilter(filterID)
if errors.Is(err, ErrNotFound) {
return nil, nil
return []types.Log{}, nil
} else if err != nil {
return RPCErrorResponse(types.DefaultErrorCode, "failed to get filter from storage", err, true)
}

if filter.Type != FilterTypeLog {
return nil, nil
return []types.Log{}, nil
}

filterParameters := filter.Parameters.(LogFilter)
Expand Down
Loading