[ManagedUI] backgroup image dimensions

[JeremyAnsel]

The exception thrown when the backgroup image ratio is invalid is not helpfull.

ProjectValidator suggests a size of 492x312 which throws a ValidationException. The exception is thrown when width > height:

wixsharp/Source/src/WixSharp/ProjectValidator.cs

Lines 98 to 119 in a248dd6

	if (project is ManagedProject && !project.BackgroundImage.IsEmpty() && project.ValidateBackgroundImage)
	{
	bool invalidAspectRatio = false;
	try
	{
	string imageFile = Utils.PathCombine(project.SourceBaseDir, project.BackgroundImage);
	if (IO.File.Exists(imageFile))
	{
	var img = Bitmap.FromFile(imageFile);
	if (img.Width > img.Height)
	invalidAspectRatio = true;
	}
	}
	catch { }
	if (invalidAspectRatio)
	throw new ValidationException(
	"Project.BackgroundImage has incompatible (with ManagedUI default dialogs) aspect ratio. The expected ratio is close to 492x312. " +
	"The background image in ManagedUI dialogs is left-docked at runtime and if it's too wide it can push away (to right) " +
	"the all other UI elements. " +
	"You can suppress image validation by setting Project.ValidateBackgroundImage to 'false'.");
	}

It is suggested to use a size of 156x312 or 164x497:

wixsharp/Source/src/WixSharp.UI/ManagedUI/Forms/WelcomeDialog.scaling.cs

Lines 50 to 51 in c766ea4

	float ratio = 156f / 312f; //matching default WiX dialog image
	ratio = 164f / 497f; //found by experiment

It would be better if the validation exception indicates the size to use.

[oleg-shilo]

Done.

The error message indeed needed the change. Thank you for that.

Please note that "WelcomeDialog.scaling.cs#L50-L51" reference is not an active code but a non-compilable records of the experiments with MSI UI.

The actual most accurate ratio is dictated by the runtime size of the PictureBox of the WelcomeDialog that can be observed in the WinForm designer.

[JeremyAnsel]

Thanks