chore: Uses go version from go.mod #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
ok to test |
gab-arrobo
reviewed
Jan 3, 2024
| @@ -31,7 +31,7 @@ jobs: | |||
|
|
|||
| - uses: actions/setup-go@v5 | |||
| with: | |||
| go-version: 1.21 | |||
| go-version-file: "go.mod" | |||
|
|
|||
| - name: Unit tests | |||
| run: go test ./... | |||
There was a problem hiding this comment.
What about adding a lint action?
Suggested change
| run: go test ./... | |
| run: go test ./... | |
| lint: | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - uses: actions/setup-go@v5 | |
| with: | |
| go-version-file: 'go.mod' | |
| - name: golangci-lint | |
| uses: golangci/golangci-lint-action@v3.7.0 | |
| with: | |
| version: latest | |
| args: -v --config ./.golangci.yml | |
There was a problem hiding this comment.
We can but I would suggest doing it in a different PR as it is independent from this change
Co-authored-by: gab-arrobo <gabriel.arrobo@intel.com>
Co-authored-by: gab-arrobo <gabriel.arrobo@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We use the go version from go.mod instead of specifying it in CI. This makes it so that when we will bump the Go version we will have to do it in less places and therefore avoids potential differences between the go version running in CI and the one in go.mod.