Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Uses go version from go.mod #51

Merged
merged 3 commits into from
Jan 3, 2024
Merged

chore: Uses go version from go.mod #51

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33928bb
chore: Uses go version from go.mod
gruyaume Jan 3, 2024
8eaefde
Update .github/workflows/master.yml
gruyaume Jan 3, 2024
5695b0c
Update .github/workflows/master.yml
gruyaume Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/master.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:

- uses: actions/setup-go@v5
with:
go-version: 1.21
go-version-file: "go.mod"
gruyaume marked this conversation as resolved.
Show resolved Hide resolved

- name: Build
run: go build
Expand All @@ -31,7 +31,7 @@ jobs:

- uses: actions/setup-go@v5
with:
go-version: 1.21
go-version-file: "go.mod"
gruyaume marked this conversation as resolved.
Show resolved Hide resolved

- name: Unit tests
run: go test ./...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about adding a lint action?

Suggested change
run: go test ./...
run: go test ./...
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version-file: 'go.mod'
- name: golangci-lint
uses: golangci/golangci-lint-action@v3.7.0
with:
version: latest
args: -v --config ./.golangci.yml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can but I would suggest doing it in a different PR as it is independent from this change