Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce spending_txhash in invalid exit events #1492

Merged
merged 5 commits into from
May 7, 2020
Merged

Introduce spending_txhash in invalid exit events #1492

merged 5 commits into from
May 7, 2020

Conversation

mederic-p
Copy link
Contributor

@mederic-p mederic-p commented Apr 28, 2020 •
edited
Loading

Closes #1482

Overview

This PR adds a new spending_txhash field to invalid_exit and unchallenged_exit events.

Changes

The hash is obtained "on the fly" when querying status.get and not persisted in the DB.

Testing

Tests have been updated to assert the validity of the hash.

@coveralls
Copy link

coveralls commented Apr 28, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 78.083% when pulling 0b51e66 on mederic-p/add-spending-info-to-events into 6520230 on master.

@mederic-p mederic-p marked this pull request as ready for review April 29, 2020 06:02
@kalouo kalouo mentioned this pull request Apr 29, 2020
Merged
@InoMurko InoMurko requested review from achiurizo and removed request for InoMurko April 29, 2020 16:55
@kalouo
Copy link

kalouo commented Apr 30, 2020 •
edited
Loading

Swagger docs update including spending_txhash included in #1495

achiurizo
achiurizo approved these changes May 4, 2020
View reviewed changes
apps/omg_watcher/test/omg_watcher/exit_processor/standard_exit_test.exs
@@ -17,7 +17,7 @@ defmodule OMG.Watcher.ExitProcessor.StandardExitTest do
Test of the logic of exit processor, in the area of standard exits
"""

use OMG.Watcher.ExitProcessor.Case, async: true
use OMG.Watcher.ExitProcessor.Case, async: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an unfortunate change.

priv/cabbage/apps/itest/test/features/in_flight_exits.feature
And Alice starts a standard exit on the child chain from her recently received input from Bob
And Alice piggybacks inputs from Bobs most recent in flight exit
And Bob fully challenges Alices most recent invalid exit
Then "Bob" can processes its own most recent in flight exit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@mederic-p mederic-p merged commit 7f65022 into master May 7, 2020
@mederic-p mederic-p deleted the mederic-p/add-spending-info-to-events branch May 7, 2020 07:13
@unnawut unnawut added api API-level issues enhancement New feature or request labels Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achiurizo achiurizo achiurizo approved these changes

@T-Dnzt T-Dnzt T-Dnzt approved these changes

@kalouo kalouo kalouo approved these changes

@pnowosie pnowosie Awaiting requested review from pnowosie

Assignees
No one assigned
Labels
api API-level issues enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Plasma spend transaction hash to invalid_exit and unchallenged_exit events
6 participants
@mederic-p @coveralls @kalouo @achiurizo @T-Dnzt @unnawut