-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce spending_txhash in invalid exit events #1492
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4faa102
feat: introduce spending_txhash in invalid exit events
e0cef32
fix: tests format
625387f
refactor
7104852
Merge branch 'master' into mederic-p/add-spending-info-to-events
0b51e66
Merge branch 'master' into mederic-p/add-spending-info-to-events
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,8 +9,24 @@ Feature: In Flight Exits | |
And Alice sends the most recently created transaction | ||
And Bob spends an output from the most recently sent transaction | ||
And Alice starts an in flight exit from the most recently created transaction | ||
Then Alice verifies its in flight exit from the most recently created transaction | ||
Then "Alice" verifies its in flight exit from the most recently created transaction | ||
Given Bob piggybacks inputs and outputs from Alices most recent in flight exit | ||
And Bob starts a piggybacked in flight exit using his most recently prepared in flight exit data | ||
And Alice fully challenges Bobs most recent invalid in flight exit | ||
Then Alice can processes her own most recent in flight exit | ||
Then "Alice" can processes its own most recent in flight exit | ||
|
||
Scenario: Standard exit invalidated with an In Flight Exit | ||
Given "Alice" deposits "10" ETH to the root chain | ||
Then "Alice" should have "10" ETH on the child chain after finality margin | ||
Given "Bob" deposits "10" ETH to the root chain | ||
Then "Bob" should have "10" ETH on the child chain after finality margin | ||
Given Bob sends Alice "5" ETH on the child chain | ||
Then "Alice" should have "15" ETH on the child chain after a successful transaction | ||
Given Alice creates a transaction spending her recently received input to Bob | ||
And Bob starts an in flight exit from the most recently created transaction | ||
Then "Bob" verifies its in flight exit from the most recently created transaction | ||
Given Bob piggybacks outputs from his most recent in flight exit | ||
And Alice starts a standard exit on the child chain from her recently received input from Bob | ||
And Alice piggybacks inputs from Bobs most recent in flight exit | ||
And Bob fully challenges Alices most recent invalid exit | ||
Then "Bob" can processes its own most recent in flight exit | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ❤️ |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is an unfortunate change.