Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pytests #207

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Update pytests #207

merged 2 commits into from
Nov 1, 2023

Conversation

zhx828
Copy link
Member

@zhx828 zhx828 commented Oct 31, 2023

No description provided.

@zhx828 zhx828 assigned bprize15 and unassigned bprize15 Oct 31, 2023
@zhx828 zhx828 requested a review from calvinlu3 October 31, 2023 22:35
@@ -16,21 +16,18 @@
from AnnotatorCore import HGVSgQuery
from AnnotatorCore import ReferenceGenome

ONCOKB_API_TOKEN = os.environ["ONCOKB_API_TOKEN"]
ONCOKB_API_TOKEN = '5d682637-c3c8-4353-b623-347d8f8ca5c2'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you accidently committed your token.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also think the tests are failing because token was removed here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😞 I will fix

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@calvinlu3 the reason the tests failing is because the fork branch cannot use the main repo secret.

Comment on lines 23 to 30
MUTATION_EFFECT_INDEX = VARIANT_EXISTS_INDEX+1
ONCOGENIC_INDEX = MUTATION_EFFECT_INDEX+2
LEVEL_1_INDEX = ONCOGENIC_INDEX+1
LEVEL_2_INDEX = LEVEL_1_INDEX+1
LEVEL_3A_INDEX = LEVEL_1_INDEX+2
HIGHEST_LEVEL_INDEX = LEVEL_1_INDEX+7
HIGHEST_DX_LEVEL_INDEX = HIGHEST_LEVEL_INDEX+7
HIGHEST_PX_LEVEL_INDEX = HIGHEST_DX_LEVEL_INDEX+5

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flake8 is complaining about no spaces around + sign.

Remove 2.7 test environment

2.7 has been removed since June 19
@zhx828 zhx828 requested a review from calvinlu3 November 1, 2023 14:21
Copy link

@calvinlu3 calvinlu3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@zhx828 zhx828 merged commit e5ef4c2 into oncokb:master Nov 1, 2023
16 of 18 checks passed
@zhx828 zhx828 deleted the update-pytests branch November 1, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants