Complete Cadence 1.0 and Atree inlining migration

[j1010001]

Issue to be solved

Problem: We are planning to run atree register inlining migration, as well as all migrations needed for Cadence 1.0 in a single network upgrade (crescendo release). This issue describes all tasks which we need to complete to have a complete migration for both features, including validation of all migrated Cadence values.


Critical Tasks:

• Migration for core contracts #2989
• Integrate Cadence 1.0 Migrations into FVM #2990
• Bump atree version in Cadence 0.42 for new features (e.g. deduplication of Cadence dictionary type info) #3177
• Bump atree version in Cadence v1.0 for new features (e.g. deduplication of Cadence dictionary type info)  #3178
• Replace hash-based validation of migrated Cadence values to use Equal() flow-go#5204
• Fix data race in account grouping for account based migration flow-go#5488
• Fix storage map key conversion in atree migration flow-go#5605
• Fix storage health check in Cadence 1.0 migration flow-go#5622
• Sync atree inlining branch with master #3179
• Atree register inlining for v1.0 #3048
• (never merge) Atree Inlining & Deduplication with Cadence v0.42 (deprecated by PR #5736) flow-go#5349
• Atree Inlining & Deduplication with Cadence v1.0 flow-go#5554
• Add storage health check flags for atree migration flow-go#5636
• Merge master into v1.0 atree register inlining feature branch #3229

Nice to have / optional / requested:

• Add feature to support mutation for array and map iterators atree#359
• Performance optimization - Change the atree register inlining migration output to “intermediate” format - registers sorted by account, which will be an input into the Cadence 1.0 migrations (this is saving time as we’d need to sort the registers again to leverage the concurrent account-based migration extracted from the Atree register inlining migration PR here: Migrate-by-account changes flow-go#5128)
• Use atree readonly iterators when mutation of values is not needed #3170
• Optimize migration by adding ability to read or extract payloads from state flow-go#5386
• Add utility to extract payloads by addresses flow-go#5389
• Add migration diff util for testing and debugging migrations flow-go#5499
• Improve validation of Cadence values in atree migration flow-go#5609

Suggested Solution

No response

[turbolent]

@j1010001 @fxamacker I think this is done now, right? OK to close?

[fxamacker]

Closed as completed. Thanks Bastian for amazing work! 🙌

[turbolent]

Awesome work Faye! 🎉🙌