Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage health check flags for atree migration #5636

Merged

Conversation

fxamacker
Copy link
Member

This PR adds debug flags to check storage health before and after atree migration.

  • check-storage-health-before
  • check-storage-health-after

@fxamacker fxamacker requested review from a team April 5, 2024 23:29
@fxamacker fxamacker self-assigned this Apr 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 13.79310% with 50 lines in your changes are missing coverage. Please review.

Project coverage is 55.54%. Comparing base (ad12394) to head (eaf2bc4).

Files Patch % Lines
...util/ledger/migrations/atree_register_migration.go 4.54% 40 Missing and 2 partials ⚠️
cmd/util/cmd/execution-state-extract/cmd.go 50.00% 4 Missing and 2 partials ⚠️
...execution-state-extract/execution_state_extract.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5636      +/-   ##
==========================================
- Coverage   55.55%   55.54%   -0.02%     
==========================================
  Files        1043     1043              
  Lines      102034   102092      +58     
==========================================
+ Hits        56689    56705      +16     
- Misses      40992    41030      +38     
- Partials     4353     4357       +4     
Flag Coverage Δ
unittests 55.54% <13.79%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fxamacker
Copy link
Member Author

@janezpodhostnik @turbolent PTAL 🙏

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fxamacker fxamacker added this pull request to the merge queue Apr 9, 2024
Merged via the queue into master with commit 54a1eef Apr 9, 2024
55 checks passed
@fxamacker fxamacker deleted the fxamacker/add-storage-health-check-flag-for-atree-migration branch April 9, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants