Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atree Inlining & Deduplication with Cadence v1.0 #5554

Conversation

fxamacker
Copy link
Member

@fxamacker fxamacker commented Mar 16, 2024

Updates Epic onflow/atree#292 and closes #5403.

Atree Inlining & Deduplication is implemented at github.com/onflow/atree:

This PR enables Atree Inlining & Deduplication with Cadence v1.0 in flow-go.

Requires:

@fxamacker fxamacker added the Execution Cadence Execution Team label Mar 16, 2024
@fxamacker fxamacker requested a review from a team March 16, 2024 00:03
@fxamacker fxamacker self-assigned this Mar 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (feature/atree-inlining-cadence-v1.0@b4864e0). Click here to learn what that means.

Files Patch % Lines
utils/unittest/execution_state.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                          Coverage Diff                           @@
##             feature/atree-inlining-cadence-v1.0    #5554   +/-   ##
======================================================================
  Coverage                                       ?   55.65%           
======================================================================
  Files                                          ?      276           
  Lines                                          ?    26638           
  Branches                                       ?        0           
======================================================================
  Hits                                           ?    14826           
  Misses                                         ?    10626           
  Partials                                       ?     1186           
Flag Coverage Δ
unittests 55.65% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fxamacker fxamacker changed the base branch from feature/stable-cadence to feature/atree-inlining-cadence-v1.0 April 18, 2024 22:08
@turbolent turbolent closed this Apr 19, 2024
@turbolent turbolent reopened this Apr 19, 2024
@turbolent
Copy link
Member

Re-triggered CI

@fxamacker fxamacker merged commit 53b0738 into feature/atree-inlining-cadence-v1.0 Apr 19, 2024
83 of 96 checks passed
@fxamacker fxamacker deleted the fxamacker/atree-register-inlining-v1.0 branch April 19, 2024 21:22
github.com/onflow/atree v0.6.1-0.20240416233652-f4568c0c03df
github.com/onflow/cadence v1.0.0-preview.21
github.com/onflow/atree v0.6.1-0.20240417191405-e11f55fa33a3
github.com/onflow/cadence v1.0.0-preview-atree-register-inlining.21
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Execution Cadence Execution Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants