Fix resource dictionary destruction and insertion with deferred values #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kay-Zee
approved these changes
May 23, 2020
|
|
||
| var returnValue Value |
There was a problem hiding this comment.
this part is no longer needed? just making sure we didn't remove it by accident.
There was a problem hiding this comment.
This was boxing the result from Insert, which used to return a Value or nil, but is now already returning an OptionalValue, so it doesn't need to be boxed up here anymore
turbolent
deleted the
bastian/fix-resource-dictionary-value-deferral-destruction
branch
SupunS
added a commit
that referenced
this pull request
Jul 11, 2023
[v0.39] Remove spurious resource loss errors (internal #130)
SupunS
pushed a commit
that referenced
this pull request
Jul 11, 2023
SupunS
added a commit
that referenced
this pull request
Jul 12, 2023
Remove spurious resource loss errors (internal #130)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #128
When a resource dictionary is destroyed or a key is updated, the value might be deferred.
Load the deferred values properly instead of only considering loaded values.
Also, simplify/reuse the existing test for ensuring deferred values are properly loaded when removing keys from resource dictionaries.
The diff looks odd, might be best reviewed by looking at the new code in split-diff mode