Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build action #170

Merged
merged 10 commits into from
Dec 8, 2022
Merged

Fix build action #170

merged 10 commits into from
Dec 8, 2022

Conversation

huyndo
Copy link
Contributor

@huyndo huyndo commented Dec 7, 2022

Upgrade checkout and setup-node to v3, node version to v16.

Change reviewer for PR to @justinbarry.

@huyndo huyndo self-assigned this Dec 7, 2022
@@ -37,6 +37,6 @@ jobs:
title: Update Built Bundle
body: This PR is automatically generated to update the build bundle of the dev-wallet which is then used by go library for integration in other tools.
assignees: sideninja
reviewers: 10thfloor
reviewers: justinbarry
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add multiple users or group?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gregsantos I think it's possible but we need to follow this as a workaround (the default github token does not have that permission so we need to create a PAT)

@huyndo huyndo marked this pull request as draft December 7, 2022 17:56
@huyndo huyndo marked this pull request as ready for review December 8, 2022 18:12
@huyndo huyndo merged commit 4e69f25 into main Dec 8, 2022
@huyndo huyndo deleted the huyndo/fix-build-action branch December 8, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants