Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build action #170

Merged
merged 10 commits into from
Dec 8, 2022
Merged

Fix build action #170

Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b40b4f9
Separate build and export
Dec 6, 2022
bccfc30
Upgrade setup to v3
Dec 6, 2022
b8154d0
Test change PR reviewer
Dec 6, 2022
8205a74
Build and export in one command
Dec 7, 2022
8bb7b42
Add correct people to PR creation
Dec 7, 2022
f5aa529
Set reviewer as fcl team
Dec 7, 2022
aa491cb
Add @ to team-reviewers name
Dec 7, 2022
f4bfc7d
Add quotes to team-reviewers name
Dec 7, 2022
b335d7d
Change team reviewer to fcl
Dec 7, 2022
16cb790
Revert change to team-reviewers
Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/build-bundle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@ jobs:
buildBundle:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
fetch-depth: 0

- name: Build Bundle
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: '14'
node-version: '16'
cache: 'npm'

- run: npm install
Expand All @@ -37,6 +37,6 @@ jobs:
title: Update Built Bundle
body: This PR is automatically generated to update the build bundle of the dev-wallet which is then used by go library for integration in other tools.
assignees: sideninja
reviewers: 10thfloor
reviewers: justinbarry
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add multiple users or group?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gregsantos I think it's possible but we need to follow this as a workaround (the default github token does not have that permission so we need to create a PAT)

branch: update-bundle
base: main