Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Balance Capability target check #296

Closed
janezpodhostnik opened this issue Jul 15, 2022 · 1 comment · Fixed by #450
Closed

Balance Capability target check #296

janezpodhostnik opened this issue Jul 15, 2022 · 1 comment · Fixed by #450
Assignees
@joshuahannan
Labels
Bug 🪲 Feature Feedback good first issue Good for newcomers Needs Estimation SC-Eng Issues that we want to see surfaced in SC-Eng ZH Board

Comments

@janezpodhostnik
Copy link
Collaborator

janezpodhostnik commented Jul 15, 2022 •
edited
Loading

Issue To Be Solved

The target of the balance capability in Flow core contracts here:

Is not verified that it is in fact targeting the default FLOW vault.

Suggest A Solution

This can be verified, using the getLinkTarget method.

But you are currently not able to due paths not being comparable onflow/cadence#1815.
A workaround would be to compare the "path.toString()" values, but this seems dirty.
@janezpodhostnik janezpodhostnik mentioned this issue Jul 15, 2022
Merged
@joshuahannan joshuahannan added good first issue Good for newcomers Bug 🪲 SC-Eng Issues that we want to see surfaced in SC-Eng ZH Board Needs Estimation labels Mar 14, 2023
@joshuahannan joshuahannan self-assigned this May 8, 2024
@joshuahannan joshuahannan moved this to 🧊 Backlog in 🌊 Flow 4D May 8, 2024
@joshuahannan
Copy link
Member

Looks like this was already addressed in FlowStorageFees but still exists in FlowServiceAccount. I'll make a PR to address it

@joshuahannan joshuahannan moved this from 🧊 Backlog to 🏗 In Progress in 🌊 Flow 4D Sep 24, 2024
@joshuahannan joshuahannan mentioned this issue Sep 26, 2024
Merged
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in 🌊 Flow 4D Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshuahannan joshuahannan

Labels
Bug 🪲 Feature Feedback good first issue Good for newcomers Needs Estimation SC-Eng Issues that we want to see surfaced in SC-Eng ZH Board
Projects
🌊 Flow 4D
Archived in project
Milestone
No milestone
2 participants
@joshuahannan @janezpodhostnik