Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add calculateAccountsCapacity to storage fees #295

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

janezpodhostnik
Copy link
Collaborator

@janezpodhostnik janezpodhostnik commented Jul 13, 2022

... for getting the storage capacity of multiple account with one call.

This is mainly intended to be used by the FVM as a performance improvement for the storage capacity check that happens at the end of every transaction.

This is related to https://github.com/dapperlabs/flow-go/issues/6308.

@bluesign
Copy link
Contributor

bluesign commented Jul 13, 2022

Maybe we can fix calculateAccountCapacity using balance interface at the same deploy?

@janezpodhostnik
Copy link
Collaborator Author

@bluesign I'm not sure what you mean.

@bluesign
Copy link
Contributor

@janezpodhostnik calculateAccountCapacity using Balance interface ( shared on different path ) , so technically you can have 2 different vaults in Balance and Vault locations.

This causes issue that transaction fees can be avoided. ( But Vault with balance to balance path, put empty vault on main vault path, storage fees satisfy and doesn't rollback transaction, but transaction fees cannot get the fee ( but accept the 0 value ) )

I commented this long ago in detail in another PR.

@janezpodhostnik
Copy link
Collaborator Author

@bluesign Its not super trivial do do this and it also includes the Flow service account contract, so I opened an issue for this #296 and I will resolve it once onflow/cadence#1815 is implemented.

@janezpodhostnik janezpodhostnik merged commit 797b149 into master Jul 20, 2022
@joshuahannan joshuahannan deleted the janez/batch-storage-capacity branch February 7, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants