Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make balance check in FlowService Account enforce that it is a FlowToken Vault #450

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Make balance check in FlowService Account enforce that it is a FlowToken Vault #450

merged 1 commit into from
Sep 27, 2024

Conversation

joshuahannan
Copy link
Member

@joshuahannan joshuahannan commented Sep 26, 2024 •
edited
Loading

Closes #296

Updates FlowServiceAccount to enforce that the Vault that is queried is a FlowToken.Vault instead of just {FungibleToken.Balance}

@joshuahannan joshuahannan assigned nvdtf and unassigned nvdtf Sep 26, 2024
@joshuahannan joshuahannan requested a review from nvdtf September 26, 2024 17:37
@joshuahannan joshuahannan merged commit 6b78d3e into master Sep 27, 2024
2 checks passed
@joshuahannan joshuahannan deleted the capability-check branch September 27, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janezpodhostnik janezpodhostnik janezpodhostnik approved these changes

@sisyphusSmiling sisyphusSmiling Awaiting requested review from sisyphusSmiling

@nvdtf nvdtf Awaiting requested review from nvdtf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Balance Capability target check
3 participants
@joshuahannan @janezpodhostnik @nvdtf