-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Access] SubscribeBlocks endpoint is missing #564
[Access] SubscribeBlocks endpoint is missing #564
Conversation
…-go, removed flow-archide dependency & storage/remote package
Nice! Is this also going to be ported to master? |
Hi, @tarakby, |
Hi @UlyanaAndrukhiv, thanks for the ping! Yes you are right, this non tagged branch is used by I also think your changes could be backported into master so they don't get lost once we're done with my branch. |
So flow-go The name of that branch looks like a temporary name. Maybe the Emulator repo should have a dedicated |
cc @sideninja: This is one of the solutions I had mentioned re: EVM. Once we have this branch, maybe EVM related PRs that are already on |
@sideninja, what are your thoughts on the discussion upper? Thank you in advance. |
We should create a branch like @turbolent suggested that is pre-cadence 1.0. As a source branch, the Taraks' branch can be used. Then if there's something that is needed to unblock we can backport changes. However I think that for the purpose of flow-go EVM work it's better to use the updated feature/cadence branch since anyhow we are preparing for Crescendo. @UlyanaAndrukhiv if you want you can create that yourself but if you need help or want me to create the base branch let me know. |
Heads up, I have created a branch off of |
I recreated a new PR #593 that targets the release/v0 branch |
FLIP: onflow/flips#229
Description
This pull request :
SubscribeBlocks
,SubscribeBlockHeaders
andSubscribeBlockDigests
methods from Access API interfaceRegisterAccessAPIServer
,StateStreamBackend
and creatingbackend.Config
according to newflow-go
package versionflow-archive
dependency &storage/remote
package #524]