Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Update default grpc message size #4596

Closed
peterargue opened this issue Aug 2, 2023 · 0 comments · Fixed by #4609
Closed

[Access] Update default grpc message size #4596

peterargue opened this issue Aug 2, 2023 · 0 comments · Fixed by #4609
Assignees
Labels

Comments

@peterargue
Copy link
Contributor

Problem Definition

Currently, the default grpc max message size used by Access and Execution nodes is 20MB:

const DefaultMaxMsgSize = 1024 * 1024 * 20

The current recommended max size on mainnet is 60MB, and most operators manage this using the cli flag --rpc-max-message-size.

Using a response side size limiter doesn't actually protect the node, since it has already done the work to generate the message. Also, the receive limit on the communication with an upstream Execution node has limited value since ENs are currently trusted. This will change, but before that happens, ANs will stop using gRPC to get data from ENs.

Proposed Solution

Update the default max message size to 1GB. This is much higher that current max data sizes and leaves room for state growth, while also putting a reasonable max on the payload sizes.

@peterargue peterargue self-assigned this Aug 2, 2023
@peterargue peterargue added S-Access good first issue Good for newcomers labels Aug 2, 2023
bors bot added a commit that referenced this issue Aug 9, 2023
4609: [Access] Update default grpc max message size to 1GiB r=peterargue a=peterargue

Closes: #4596

The amount of data returned from some Access API requests has increased over time, resulting in response size errors on Access and Execution nodes. While the max message size is configurable via CLI flags, this PR updates the default to be well above the current largest messages.

Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant