[Access] Update default grpc max message size to 1GiB #4609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4609 +/- ##
==========================================
+ Coverage 54.63% 54.67% +0.03%
==========================================
Files 915 915
Lines 85445 85445
==========================================
+ Hits 46687 46716 +29
+ Misses 35170 35141 -29
Partials 3588 3588
Flags with carried forward coverage won't be shown. Click here to find out more.
|
janezpodhostnik
approved these changes
Aug 9, 2023
It wouldn't hurt, but it's only needed if they are using this setting directly from |
Kay-Zee
approved these changes
Aug 9, 2023
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Aug 9, 2023
4609: [Access] Update default grpc max message size to 1GiB r=peterargue a=peterargue Closes: #4596 The amount of data returned from some Access API requests has increased over time, resulting in response size errors on Access and Execution nodes. While the max message size is configurable via CLI flags, this PR updates the default to be well above the current largest messages. Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
|
Build failed: |
koko1123
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4596
The amount of data returned from some Access API requests has increased over time, resulting in response size errors on Access and Execution nodes. While the max message size is configurable via CLI flags, this PR updates the default to be well above the current largest messages.