Clean up DKG simulation in bootstrap

[tarakby]

The key generation required by the Flow random beacon is basically a BLS threshold signature key generation. While such generation can be done in a multi-party way (in a distributed manner), it can simply be done by a single-party playing the role of a secret sharing dealer.
The distributed version is suitable for multi-party trustless protocols in production mode. The simple method is enough for a single-party mode with a trusted setup, such is the case of bootstrap and tests.

Tests and network bootstraps are centralized processes happening on a single machine. The distributed version can only happen by simulating a network of multiple nodes and their communication (too complex for the these use cases). Such simulation is implemented in the crypto package tests, to test the DKG itself, but doesn't need to be used in other cases.

This PR deletes the option to use the simulated distributed version from bootstraps and tests:

• update the name of the generation function to RandomBeaconKeyGen since there is nothing distributed to justify the D of DKG.
• remove the key generation flag option from the bootstrap commands. The simple key generation is the only algorithm used.

[codecov-commenter]

Codecov Report

Merging #4259 (b16c645) into master (ad864f3) will increase coverage by 0.21%.
The diff coverage is 62.26%.

@@            Coverage Diff             @@
##           master    #4259      +/-   ##
==========================================
+ Coverage   53.52%   53.74%   +0.21%     
==========================================
  Files         837      863      +26     
  Lines       78436    80043    +1607     
==========================================
+ Hits        41985    43020    +1035     
- Misses      33100    33635     +535     
- Partials     3351     3388      +37     

Flag	Coverage Δ
unittests	53.74% <62.26%> (+0.21%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cmd/bootstrap/cmd/constraints.go	71.42% <ø> (+8.16%)	⬆️
cmd/execution_builder.go	0.00% <0.00%> (ø)
cmd/execution_config.go	0.00% <ø> (ø)
cmd/scaffold.go	14.59% <0.00%> (-0.14%)	⬇️
...ck-executed-height/cmd/rollback_executed_height.go	15.69% <ø> (-0.69%)	⬇️
cmd/util/ledger/reporters/account_reporter.go	0.00% <0.00%> (ø)
cmd/utils.go	14.58% <ø> (+1.85%)	⬆️
cmd/verification_builder.go	0.00% <0.00%> (ø)
consensus/hotstuff/pacemaker/timeout/config.go	75.36% <ø> (+4.34%)	⬆️
consensus/hotstuff/pacemaker/timeout/controller.go	48.61% <ø> (ø)
... and 112 more

... and 62 files with indirect coverage changes

[tarakby]

bors merge

[bors]

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

• Integration Tests (make -C integration access-tests)
• Integration Tests (make -C integration bft-tests)
• Integration Tests (make -C integration collection-tests)
• Integration Tests (make -C integration consensus-tests)
• Integration Tests (make -C integration epochs-tests)
• Integration Tests (make -C integration execution-tests)
• Integration Tests (make -C integration ghost-tests)
• Integration Tests (make -C integration mvp-tests)
• Integration Tests (make -C integration network-tests)
• Integration Tests (make -C integration verification-tests)
• Lint (./)
• Lint (./crypto/)
• Lint (./integration/)
• Unit Tests (access)
• Unit Tests (admin)
• Unit Tests (cmd)
• Unit Tests (consensus)
• Unit Tests (engine)
• Unit Tests (fvm)
• Unit Tests (ledger)
• Unit Tests (module)
• Unit Tests (network)
• Unit Tests (others)
• Unit Tests (utils)