[randomness final part] Update math/rand usage
#4052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FVM Benchstat comparisonThis branch with compared with the base branch onflow:master commit 117fcc0 The command Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov Report
@@ Coverage Diff @@
## master #4052 +/- ##
==========================================
- Coverage 56.25% 54.40% -1.86%
==========================================
Files 653 914 +261
Lines 64699 85199 +20500
==========================================
+ Hits 36396 46351 +9955
- Misses 25362 35263 +9901
- Partials 2941 3585 +644
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tarakby
requested review from
SaveTheRbtz,
pattyshack,
gomisha,
yhassanzadeh13,
vishalchangrani and
ramtinms
as code owners
pattyshack
suggested changes
Jun 12, 2023
peterargue
reviewed
Jun 12, 2023
Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
peterargue
reviewed
Jun 14, 2023
|
@peterargue I'm thinking of adding a Makefile target that checks [Update]: I added this check. |
tarakby
force-pushed
the
tarak/go1.20-rand-prep
branch
from
bac7d61 to
14df98f
Compare
tarakby
force-pushed
the
tarak/go1.20-rand-prep
branch
from
b09f12b to
e3447dc
Compare
yhassanzadeh13
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the last of multiple small PRs updating the usage of
math/randin all the repo, for two purposes:math/randin production code (seed length is too short, randomness quality is low)math/randcan be used in test files, the functionsSeedandReadare deprecated in Go1.20 and should not be used as the repo prepares to upgrade the Go version.Previous related PRs include:
This final PR of the list has the following changes:
IdentifierandIdentifierListrandom functions to useutils/rand(backed by securecrypto/rand) instead of relying onmath/rand. The random functions areSample,Shuffle,SamplePct.math/randPRG inDefaultLibp2pBackoffConnectorFactoryby a secure PRG (cc @yhassanzadeh13)math/randfunctionsSeedandReadfrom test files (this means some tests are now deterministic! which is temporary till Go1.20 is used), and usecrypto/randin some tests.math/randis not imported in production code, to avoid the package is re-introduced in the future.