[randomness part 8] update math/rand usage in /cmd/bootstrap

[tarakby]

This is part of the work started in #4052.

Context is to update the usage of math/rand in all the repo, for two purposes:

• move on from using math/rand in production code (seed length is too short, randomness quality isn't suited for production)
• even though math/rand can be used in test files, the functions Seed and Read are deprecated in Go1.20 and should not be used as the repo prepares to upgrade the Go version.

This PR updated /cmd/bootstrap:

• replace deterministic clustering (based on math/rand) by non-deterministic clustering (based on crypto/rand).
• remove the bootstrap seed flag that used to seed the deterministic process
• the cluster assignment only outputs clusters satisfying the internal/partner nodes requirement (the later check is only a sanity check) - clarify the deterministic properties of the algorithm.
• Epoch's random source is set non-deterministically based on crypto/rand in :
  • execution state generation
  • root result generation
• clean up tests

[codecov-commenter]

Codecov Report

Merging #4362 (86bc599) into master (b427320) will decrease coverage by 0.12%.
The diff coverage is 55.76%.

@@            Coverage Diff             @@
##           master    #4362      +/-   ##
==========================================
- Coverage   53.75%   53.63%   -0.12%     
==========================================
  Files         871      882      +11     
  Lines       80769    82048    +1279     
==========================================
+ Hits        43420    44010     +590     
- Misses      33915    34553     +638     
- Partials     3434     3485      +51     

Flag	Coverage Δ
unittests	53.63% <55.76%> (-0.12%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cmd/bootstrap/cmd/rootblock.go	90.54% <ø> (+3.79%)	⬆️
cmd/bootstrap/utils/file.go	0.00% <0.00%> (ø)
cmd/execution_builder.go	0.00% <0.00%> (ø)
cmd/scaffold.go	14.50% <0.00%> (-0.20%)	⬇️
...ck-executed-height/cmd/rollback_executed_height.go	15.69% <0.00%> (ø)
cmd/verification_builder.go	0.00% <0.00%> (ø)
consensus/config.go	0.00% <0.00%> (ø)
consensus/hotstuff/pacemaker/timeout/controller.go	47.14% <ø> (-1.47%)	⬇️
...s/hotstuff/timeoutaggregator/timeout_aggregator.go	70.31% <ø> (ø)
...sus/hotstuff/timeoutcollector/timeout_collector.go	100.00% <ø> (ø)
... and 67 more

... and 11 files with indirect coverage changes

[tarakby]

background discussion about this change happened in another PR: #4052 (comment)

[jordanschalm]

I think we can further cleanup the cluster constraint checking, by removing the now-extraneous checkClusterConstraint. Otherwise looks good!

[tarakby]

bors merge

[bors]

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

• Integration Tests (make -C integration access-tests)
• Integration Tests (make -C integration bft-tests)
• Integration Tests (make -C integration collection-tests)
• Integration Tests (make -C integration consensus-tests)
• Integration Tests (make -C integration epochs-tests)
• Integration Tests (make -C integration execution-tests)
• Integration Tests (make -C integration ghost-tests)
• Integration Tests (make -C integration mvp-tests)
• Integration Tests (make -C integration network-tests)
• Integration Tests (make -C integration verification-tests)
• Lint (./)
• Lint (./crypto/)
• Lint (./integration/)
• Unit Tests (access)
• Unit Tests (admin)
• Unit Tests (cmd)
• Unit Tests (consensus)
• Unit Tests (engine)
• Unit Tests (fvm)
• Unit Tests (ledger)
• Unit Tests (module)
• Unit Tests (network)
• Unit Tests (others)
• Unit Tests (utils)