[Access] Refactor Access RPC engines to support a single gRPC port #4217 #4411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pc and state_stream engines, refactored access_node_builder
peterargue
reviewed
Jun 7, 2023
peterargue
reviewed
Jul 4, 2023
| @@ -612,8 +617,7 @@ func (builder *FlowAccessNodeBuilder) BuildExecutionDataRequester() *FlowAccessN | |||
| node.RootChainID, | |||
| builder.executionDataConfig.InitialBlockHeight, | |||
| highestAvailableHeight, | |||
| builder.apiRatelimits, | |||
| builder.apiBurstlimits, | |||
| builder.unsecureGrpcServer, | |||
There was a problem hiding this comment.
previously, this could be configured on a separate port. Please keep that functionality, but add support for configuring it on the same port.
Codecov Report
@@ Coverage Diff @@
## master #4411 +/- ##
==========================================
- Coverage 54.48% 53.66% -0.83%
==========================================
Files 914 750 -164
Lines 85356 72536 -12820
==========================================
- Hits 46505 38924 -7581
+ Misses 35262 30743 -4519
+ Partials 3589 2869 -720
Flags with carried forward coverage won't be shown. Click here to find out more.
|
peterargue
approved these changes
Jul 7, 2023
durkmurder
reviewed
Jul 20, 2023
durkmurder
reviewed
Jul 20, 2023
durkmurder
reviewed
Jul 20, 2023
durkmurder
approved these changes
Jul 20, 2023
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jul 21, 2023
4411: [Access] Refactor Access RPC engines to support a single gRPC port #4217 r=durkmurder a=UlyanaAndrukhiv #4217 ### Context This pull request * creates a new grpcserver module which includes a GrpcServer and a GrpcServerBuilder for it. GrpcServer defines a grpc server that starts once and uses in different Engines * refactored the Access RPC engine and state stream engine setup using the same grps server. Also small refactored Observer node's engine setup * refactored tests according to new changes Co-authored-by: UlyanaAndrukhiv <u.andrukhiv@gmail.com> Co-authored-by: Uliana Andrukhiv <u.andrukhiv@gmail.com>
|
Build failed: |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Jul 21, 2023
4411: [Access] Refactor Access RPC engines to support a single gRPC port #4217 r=durkmurder a=UlyanaAndrukhiv #4217 ### Context This pull request * creates a new grpcserver module which includes a GrpcServer and a GrpcServerBuilder for it. GrpcServer defines a grpc server that starts once and uses in different Engines * refactored the Access RPC engine and state stream engine setup using the same grps server. Also small refactored Observer node's engine setup * refactored tests according to new changes Co-authored-by: UlyanaAndrukhiv <u.andrukhiv@gmail.com> Co-authored-by: Uliana Andrukhiv <u.andrukhiv@gmail.com>
|
Build failed: |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Jul 21, 2023
4411: [Access] Refactor Access RPC engines to support a single gRPC port #4217 r=durkmurder a=UlyanaAndrukhiv #4217 ### Context This pull request * creates a new grpcserver module which includes a GrpcServer and a GrpcServerBuilder for it. GrpcServer defines a grpc server that starts once and uses in different Engines * refactored the Access RPC engine and state stream engine setup using the same grps server. Also small refactored Observer node's engine setup * refactored tests according to new changes Co-authored-by: UlyanaAndrukhiv <u.andrukhiv@gmail.com> Co-authored-by: Uliana Andrukhiv <u.andrukhiv@gmail.com>
|
Build failed: |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Jul 21, 2023
4411: [Access] Refactor Access RPC engines to support a single gRPC port #4217 r=durkmurder a=UlyanaAndrukhiv #4217 ### Context This pull request * creates a new grpcserver module which includes a GrpcServer and a GrpcServerBuilder for it. GrpcServer defines a grpc server that starts once and uses in different Engines * refactored the Access RPC engine and state stream engine setup using the same grps server. Also small refactored Observer node's engine setup * refactored tests according to new changes Co-authored-by: UlyanaAndrukhiv <u.andrukhiv@gmail.com> Co-authored-by: Uliana Andrukhiv <u.andrukhiv@gmail.com>
|
Build failed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4217
Context
This pull request