[Access] Add grpc streaming metrics #4540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4540 +/- ##
==========================================
+ Coverage 54.09% 54.45% +0.35%
==========================================
Files 563 911 +348
Lines 56220 85076 +28856
==========================================
+ Hits 30414 46329 +15915
- Misses 23459 35171 +11712
- Partials 2347 3576 +1229
Flags with carried forward coverage won't be shown. Click here to find out more.
|
yhassanzadeh13
approved these changes
Jul 6, 2023
koko1123
approved these changes
Jul 6, 2023
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jul 6, 2023
4540: [Access] Add grpc streaming metrics r=peterargue a=peterargue Currently, the state streaming API only records unary grpc metrics. This PR adds support for collecting streaming grpc metrics as well. Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
|
Build failed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the state streaming API only records unary grpc metrics. This PR adds support for collecting streaming grpc metrics as well.