Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Add grpc streaming metrics - v0.31 backport #4541

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

peterargue
Copy link
Contributor

Backports: #4540

Currently, the state streaming API only records unary grpc metrics. This PR adds support for collecting streaming grpc metrics as well.

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2023

Codecov Report

Merging #4541 (4a0be3d) into v0.31 (002d755) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##            v0.31    #4541      +/-   ##
==========================================
+ Coverage   53.76%   53.79%   +0.03%     
==========================================
  Files         893      893              
  Lines       84577    84583       +6     
==========================================
+ Hits        45469    45498      +29     
+ Misses      35565    35542      -23     
  Partials     3543     3543              
Flag Coverage Δ
unittests 53.79% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
engine/access/state_stream/engine.go 0.00% <0.00%> (ø)

... and 11 files with indirect coverage changes

@peterargue peterargue merged commit ff2a1d7 into v0.31 Jul 6, 2023
@peterargue peterargue deleted the petera/add-streaming-metrics-v0.31 branch July 6, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants