[Sync] Sync master to feature/dynamic-protocol-state
#4578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…naAndrukhiv/3138-rest-api-on-observers
4572: `scriptExecutor` should populate env values even when the script errors r=janezpodhostnik a=m-Peter While working on Flow Emulator, trying to aggregate `computationUsed` and `memoryEstimate` metrics for scripts & transactions, I stumbled upon something that seems like a bug. When a script is reverted, e.g. due to exceeding computation limit, the `ProcedureOutput` is not properly populated. **Before:** `computationUsed` & `memoryEstimate` are both `0`  **After:** `computationUsed` & `memoryEstimate` are both set  This is due to the fact that `scriptExecutor.executeScript()` returns early when it errors, and never calls `executor.output.PopulateEnvironmentValues(executor.env)` **Note:** I can complement with a relevant test case, if you can point me to the most appropriate test file. I was not able to find a fitting place for this test case. Co-authored-by: Ardit Marku <markoupetr@gmail.com> Co-authored-by: Janez Podhostnik <67895329+janezpodhostnik@users.noreply.github.com>
…ngle-gRPC-port
…st-api-on-observers
durkmurder
requested review from
peterargue,
gomisha,
yhassanzadeh13,
zhangchiqing,
tarakby,
ramtinms,
janezpodhostnik and
AlexHentschel
as code owners
Codecov Report
@@ Coverage Diff @@
## feature/dynamic-protocol-state #4578 +/- ##
==================================================================
+ Coverage 56.25% 56.83% +0.58%
==================================================================
Files 653 494 -159
Lines 64699 44194 -20505
==================================================================
- Hits 36396 25119 -11277
+ Misses 25362 17183 -8179
+ Partials 2941 1892 -1049
Flags with carried forward coverage won't be shown. Click here to find out more.
|
peterargue
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.