[Dynamic Protocol State] State machine handles invalid state transition #4922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/flow-go into yurii/4649-handle-invalid-state-transition
|
also addresses this comment in the prior PR: #4868 (comment) |
…/flow-go into yurii/4649-handle-invalid-state-transition
|
A possibly different implementation exists in parallel PR, details here |
|
Closing if favor of #4931 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR addresses high priority item from #4649 to consolidate logic of handling service events when invalid state transition has been detected.
In this PR all state machine modifications are treated as one atomic state transition. It either succeeds in its entirety or in case of a failure, there is no update to the protocol state. If invalid state transition has been detected we return a copy of the
parentStatewith only theInvalidStateTransitionAttemptedset to true.