[Dynamic Protocol State] Dedicated protocol state machine for epoch fallback #4931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanschalm
reviewed
Nov 6, 2023
Co-authored-by: Jordan Schalm <jordan@dapperlabs.com>
durkmurder
changed the base branch from
yurii/4649-handle-invalid-state-transition
to
yurii/5517-extend-payload
…/flow-go into yurii/4649-epoch-fallback-statemachine-attempt-1
…ateMachine to return if event was applied
… fallback state machine
jordanschalm
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Looks good to me.
Personally, I would still like to change the name of the flag for epoch fallback, as mentioned here. Not a blocker, though.
…/flow-go into yurii/4649-epoch-fallback-statemachine-attempt-1
Base automatically changed from
yurii/5517-extend-payload
to
feature/dynamic-protocol-state
November 14, 2023 19:38
…nflow/flow-go into yurii/4649-epoch-fallback-statemachine-attempt-1
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/dynamic-protocol-state #4931 +/- ##
==================================================================
+ Coverage 56.14% 56.18% +0.03%
==================================================================
Files 974 967 -7
Lines 90574 90142 -432
==================================================================
- Hits 50853 50646 -207
+ Misses 35934 35712 -222
+ Partials 3787 3784 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AlexHentschel
approved these changes
Nov 16, 2023
state/protocol/protocol_state/epoch_fallback_statemachine_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander Hentschel <alex.hentschel@axiomzen.co>
Co-authored-by: Alexander Hentschel <alex.hentschel@axiomzen.co>
durkmurder
deleted the
yurii/4649-epoch-fallback-statemachine-attempt-1
branch
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR addresses high priority item from #4649 to consolidate logic of handling service events when invalid state transition has been detected.
In this PR all state machine modifications are treated as one atomic state transition. It either succeeds in its entirety or in case of a failure, there is no update to the protocol state. If invalid state transition has been detected we a special version of protocol state machine for epoch fallback mode. Whenever we have entered epoch fallback mode we will re-process all the events in that block and continue using epoch fallback state machine for subsequent blocks. EFM state machine ignores epoch events and doesn't perform transitions to next epoch but it still handles ejection events.
Most of the implementation is following Alex's comment