Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storehouse] Add Extending block snapshot #5008

Merged
merged 6 commits into from
Nov 18, 2023

Conversation

zhangchiqing
Copy link
Member

@zhangchiqing zhangchiqing commented Nov 10, 2023

Working towards #4682

Close #4996

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (9b0633e) 56.20% compared to head (27715b2) 56.11%.

Files Patch % Lines
utils/unittest/fixtures.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5008      +/-   ##
==========================================
- Coverage   56.20%   56.11%   -0.09%     
==========================================
  Files         973      962      -11     
  Lines       90634    89060    -1574     
==========================================
- Hits        50937    49974     -963     
+ Misses      35891    35336     -555     
+ Partials     3806     3750      -56     
Flag Coverage Δ
unittests 56.11% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhangchiqing zhangchiqing force-pushed the leo/storehouse-extending-block-snapshot branch from 386ccef to 0eebf10 Compare November 16, 2023 17:29
@zhangchiqing zhangchiqing marked this pull request as ready for review November 16, 2023 17:29
@zhangchiqing zhangchiqing requested review from koko1123, janezpodhostnik, sideninja and peterargue and removed request for ramtinms November 17, 2023 17:06
@zhangchiqing zhangchiqing force-pushed the leo/storehouse-extending-block-snapshot branch from 27715b2 to 904bed0 Compare November 18, 2023 00:42
@zhangchiqing zhangchiqing added this pull request to the merge queue Nov 18, 2023
Merged via the queue into master with commit 538e72e Nov 18, 2023
54 checks passed
@zhangchiqing zhangchiqing deleted the leo/storehouse-extending-block-snapshot branch November 18, 2023 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Storehouse-based Execution Snapshot for FVM
4 participants