Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Circuit breaker too restrictive #5010

Merged

Conversation

Guitarheroua
Copy link
Contributor

#4910

Added error filtering for CB to bypass some gRPC errors.

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (642635d) 56.25% compared to head (c472180) 56.28%.

Files Patch % Lines
engine/access/rpc/connection/manager.go 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5010      +/-   ##
==========================================
+ Coverage   56.25%   56.28%   +0.03%     
==========================================
  Files         975      975              
  Lines       90860    90872      +12     
==========================================
+ Hits        51113    51149      +36     
+ Misses      35937    35913      -24     
  Partials     3810     3810              
Flag Coverage Δ
unittests 56.28% <91.66%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Guitarheroua Guitarheroua marked this pull request as ready for review November 14, 2023 12:33
Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any way to incorporate this into the existing tests?

@Guitarheroua Guitarheroua added this pull request to the merge queue Nov 27, 2023
Merged via the queue into onflow:master with commit 8dd3ba0 Nov 27, 2023
54 checks passed
@Guitarheroua Guitarheroua deleted the guitarheroua/4910-cb-too-restrictive branch November 27, 2023 14:44
peterargue pushed a commit that referenced this pull request Dec 12, 2023
…estrictive

[Access] Circuit breaker too restrictive
peterargue pushed a commit that referenced this pull request Dec 12, 2023
…estrictive

[Access] Circuit breaker too restrictive
peterargue pushed a commit that referenced this pull request Dec 13, 2023
…estrictive

[Access] Circuit breaker too restrictive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants