Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestions for PR #5113 #5132

Merged
merged 8 commits into from
Dec 12, 2023
Merged

Suggestions for PR #5113 #5132

merged 8 commits into from
Dec 12, 2023

Conversation

AlexHentschel
Copy link
Member

Optional suggestions for PR #5113

  • extended and polished documentation of EpochCommitSafetyThreshold() in the GlobalParams interface ( state/protocol/params.go)
  • in badger.State:
    • renamed protocol state's internal cachedFinal and cachedSealed to indicate in the variable names that these are the latest values
    • removed transaction.WithTx in a couple more places and used transaction.Tx instead
  • minor polishing of goDoc of interface protocol.Params and its implementation
  • removed outdated error checks where functions now don't return any error variable anymore
  • removed some white spaces in a few places

Alexander Hentschel added 8 commits December 9, 2023 14:48
extended and polished documentation of EpochCommitSafetyThreshold()…
0f06b68 
… in the `GlobalParams` interface (` state/protocol/params.go`)
removed transaction.WithTx and consolidated APIs of service methods…
2acd236 
… to uniformly return functors `func(*transaction.Tx) error`
removed some white spaces
28793bf
Merge branch 'yurii/instance-params-refactoring' into alex/PR-5113_-_…
9636507 
…suggestions

# Conflicts:
#	state/protocol/badger/state.go
polished and consolidated revisions after merge
12c8fd2
renamed protocol state's internal cachedFinal and cachedSealed to…
4a1d387 
… indicate in the variable names that these are the **latest** values
minor updates and polishing of goDoc
0366719
removed outdated error checks -- functions now don't return any error…
a4e5fba 
… variable anymore
@AlexHentschel AlexHentschel mentioned this pull request Dec 12, 2023
Merged
@durkmurder durkmurder merged commit 412c815 into yurii/instance-params-refactoring Dec 12, 2023
@durkmurder durkmurder deleted the alex/PR-5113_-_suggestions branch December 12, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durkmurder durkmurder durkmurder approved these changes

@jordanschalm jordanschalm Awaiting requested review from jordanschalm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexHentschel @durkmurder