Code

Suggestions for PR #5113#5132

Code

Merged

durkmurder merged 8 commits intoyurii/instance-params-refactoringonflow/flow-go:yurii/instance-params-refactoringfrom alex/PR-5113_-_suggestionsonflow/flow-go:alex/PR-5113_-_suggestionsCopy head branch name to clipboardDec 12, 2023

+84-96

Commits

Commits on Dec 9, 2023

• extended and polished documentation of EpochCommitSafetyThreshold() in the GlobalParams interface ( state/protocol/params.go)

  

  Alexander Hentschel

  committed
  0f06b68

• removed transaction.WithTx and consolidated APIs of service methods to uniformly return functors func(*transaction.Tx) error

  

  Alexander Hentschel

  committed
  2acd236

Commits on Dec 12, 2023

• removed some white spaces

  

  Alexander Hentschel

  committed
  28793bf

• Merge branch 'yurii/instance-params-refactoring' into alex/PR-5113_-_suggestions

  Show description for 9636507
  

  Alexander Hentschel

  committed
  9636507

• polished and consolidated revisions after merge

  

  Alexander Hentschel

  committed
  12c8fd2

• renamed protocol state's internal cachedFinal and cachedSealed to indicate in the variable names that these are the **latest** values

  

  Alexander Hentschel

  committed
  4a1d387

• minor updates and polishing of goDoc

  

  Alexander Hentschel

  committed
  0366719

• removed outdated error checks -- functions now don't return any error variable anymore

  

  Alexander Hentschel

  committed
  a4e5fba