Unify system-contracts migration and staged-contracts migration #5405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/stable-cadence #5405 +/- ##
==========================================================
+ Coverage 56.37% 57.74% +1.37%
==========================================================
Files 1030 839 -191
Lines 100057 82907 -17150
==========================================================
- Hits 56403 47873 -8530
+ Misses 39394 31373 -8021
+ Partials 4260 3661 -599
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SupunS
commented
Feb 16, 2024
Comment on lines
+26
to
+29
| const contractA = ` | ||
| access(all) contract A { | ||
| access(all) fun foo() {} | ||
| }` |
There was a problem hiding this comment.
Tests below would now have to use valid contract codes, once/if the update validator is enabled.
So I replaced the dummy codes with valid cadence codes.
SupunS
changed the title
SupunS
force-pushed
the
supun/contract-update-validator
branch
from
eff3173 to
4d7d75d
Compare
SupunS
commented
Feb 16, 2024
turbolent
reviewed
Feb 16, 2024
SupunS
commented
Feb 17, 2024
SupunS
changed the title
…ow-go into supun/contract-update-validator
turbolent
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards onflow/cadence#2865
Depends on onflow/cadence#3117
Validator is disabled by default.
I also realized the core-contract migration and the staged contract migration contains a lot of duplicate logic.
Hence refactored the core-contracts migration (
ChangeContractCodeMigration) to also use theStagedContractMigrationunderneath. Core contract changes are also in a way, a set of staged contract changes.