Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FT/NFT type change rules for contract update validator #5415

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Feb 20, 2024

Depends on #5405

Allows changing composite type from T to R.
e.g: @FungibleToken.Vault to @{FungibleToken.Vault}

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Let's get the dependency (#3120) in first and tag a new Cadence release

cmd/util/ledger/migrations/cadence.go Outdated Show resolved Hide resolved
@SupunS SupunS force-pushed the supun/contract-update-validator-2 branch from 597d53a to c86ba7e Compare February 20, 2024 18:17
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Base automatically changed from supun/contract-update-validator to feature/stable-cadence February 23, 2024 18:35
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.50%. Comparing base (9bcc862) to head (9bcc862).

❗ Current head 9bcc862 differs from pull request most recent head ffdf326. Consider uploading reports for the commit ffdf326 to get more accurate results

Additional details and impacted files
@@                   Coverage Diff                   @@
##           feature/stable-cadence    #5415   +/-   ##
=======================================================
  Coverage                   60.50%   60.50%           
=======================================================
  Files                         642      642           
  Lines                       60838    60838           
=======================================================
  Hits                        36809    36809           
  Misses                      21339    21339           
  Partials                     2690     2690           
Flag Coverage Δ
unittests 60.50% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turbolent turbolent merged commit ceb57fb into feature/stable-cadence Feb 23, 2024
50 of 51 checks passed
@turbolent turbolent deleted the supun/contract-update-validator-2 branch February 23, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants