[Execution] Remove duplicated observer collection indexer #5521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangchiqing
force-pushed
the
leo/remove-dup-observer-collection-indexer
branch
from
9b18a0a to
f7a374a
Compare
zhangchiqing
commented
Mar 7, 2024
| @@ -220,7 +220,6 @@ func (builder *ExecutionNodeBuilder) LoadComponentsAndModules() { | |||
| // TODO: will re-visit this once storehouse has implemented new WAL for checkpoint file of | |||
| // payloadless trie. | |||
| // Component("execution data pruner", exeNode.LoadExecutionDataPruner). | |||
| Component("observer collection indexer", exeNode.LoadObserverCollectionIndexer). | |||
There was a problem hiding this comment.
The same component is initialized in L239, this is to remove a duplicated component.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5521 +/- ##
==========================================
+ Coverage 55.74% 55.85% +0.11%
==========================================
Files 978 1030 +52
Lines 96397 100843 +4446
==========================================
+ Hits 53737 56330 +2593
- Misses 38450 40179 +1729
- Partials 4210 4334 +124
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
peterargue
approved these changes
Mar 7, 2024
janezpodhostnik
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a merge issue