Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Execution] Remove duplicated observer collection indexer #5521

Merged
merged 2 commits into from
Mar 8, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cmd/execution_builder.go
Original file line number Diff line number Diff line change
@@ -220,7 +220,6 @@ func (builder *ExecutionNodeBuilder) LoadComponentsAndModules() {
// TODO: will re-visit this once storehouse has implemented new WAL for checkpoint file of
// payloadless trie.
// Component("execution data pruner", exeNode.LoadExecutionDataPruner).
Component("observer collection indexer", exeNode.LoadObserverCollectionIndexer).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same component is initialized in L239, this is to remove a duplicated component.

Component("blob service", exeNode.LoadBlobService).
Component("block data upload manager", exeNode.LoadBlockUploaderManager).
Component("GCP block data uploader", exeNode.LoadGCPBlockDataUploader).