Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EVM] Offchain package - part 1 #6544

Merged
merged 9 commits into from
Oct 16, 2024
Merged

[EVM] Offchain package - part 1 #6544

merged 9 commits into from
Oct 16, 2024

Conversation

ramtinms
Copy link
Contributor

@ramtinms ramtinms commented Oct 7, 2024

Context:
Offchain package allows off-chain software like (GW) to follow the EVM chain and be able to replay all transactions. It also facilitates running queries (e.g. eth_Call), making the complex internal details hidden from the user.

This PR

  • makes small changes without any logic change, mostly preparing the stage for the following PRs.
  • adds Blocks supporting a storage-based blocks data provider, used later in the package, this removes the need to expose a secondary interface, when re-executing transactions.

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 64.46281% with 43 lines in your changes missing coverage. Please review.

Project coverage is 41.28%. Comparing base (3ba181e) to head (efcae1c).

Files with missing lines Patch % Lines
fvm/evm/types/result.go 0.00% 27 Missing ⚠️
fvm/evm/offchain/blocks/blocks.go 79.31% 6 Missing and 6 partials ⚠️
fvm/evm/events/events.go 66.66% 1 Missing and 1 partial ⚠️
fvm/evm/offchain/blocks/meta.go 92.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6544   +/-   ##
=======================================
  Coverage   41.28%   41.28%           
=======================================
  Files        2031     2033    +2     
  Lines      145883   145981   +98     
=======================================
+ Hits        60222    60264   +42     
- Misses      79442    79488   +46     
- Partials     6219     6229   +10     
Flag Coverage Δ
unittests 41.28% <64.46%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramtinms ramtinms marked this pull request as ready for review October 7, 2024 23:07
@ramtinms ramtinms changed the title [EVM] Offchain package - part1 [EVM] Offchain package - part 1 Oct 7, 2024
fvm/evm/types/result.go Outdated Show resolved Hide resolved
fvm/evm/offchain/blocks/blocks.go Show resolved Hide resolved
Copy link
Collaborator

@m-Peter m-Peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

fvm/evm/types/result.go Outdated Show resolved Hide resolved
fvm/evm/types/result.go Outdated Show resolved Hide resolved
@ramtinms ramtinms enabled auto-merge October 16, 2024 15:48
@ramtinms ramtinms added this pull request to the merge queue Oct 16, 2024
Merged via the queue into master with commit 0dde730 Oct 16, 2024
55 checks passed
@ramtinms ramtinms deleted the ramtin/evm-offchain-part1 branch October 16, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants