Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy slice when setting block hash list - Port #6740

Merged
merged 13 commits into from
Nov 19, 2024
Merged

Conversation

janezpodhostnik
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 65.43210% with 56 lines in your changes missing coverage. Please review.

Project coverage is 41.56%. Comparing base (4162017) to head (cf177b5).

Files with missing lines Patch % Lines
fvm/evm/types/result.go 0.00% 33 Missing ⚠️
fvm/evm/offchain/blocks/blocks.go 73.13% 12 Missing and 6 partials ⚠️
fvm/evm/offchain/blocks/meta.go 93.02% 2 Missing and 1 partial ⚠️
fvm/evm/events/events.go 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            v0.37    #6740    +/-   ##
========================================
  Coverage   41.55%   41.56%            
========================================
  Files        2026     2028     +2     
  Lines      181069   181202   +133     
========================================
+ Hits        75248    75318    +70     
- Misses      99595    99651    +56     
- Partials     6226     6233     +7     
Flag Coverage Δ
unittests 41.56% <65.43%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@j1010001 j1010001 requested a review from fxamacker November 19, 2024 19:57
@j1010001 j1010001 merged commit 39b6c7f into v0.37 Nov 19, 2024
55 checks passed
@j1010001 j1010001 deleted the janez/port-evm-fixes branch November 19, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants