Fixes nightly build 9/29 #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…earn pipeline (#522) * Add CastRegressor Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
* Fix nightly build Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
* add full tutorial to the documentation Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
* upgrade version to 1.7.1 Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
wenbingl
reviewed
Sep 29, 2020
| @@ -20,8 +20,8 @@ class TestSklearnTfidfVectorizerPipeline(unittest.TestCase): | |||
| def common_test_model_tfidf_vectorizer_pipeline_cls( | |||
| self, kind=None, verbose=False): | |||
| if kind == 'stop': | |||
| if ort_version.startswith('1.4'): | |||
| # regression with stopwords in onnxruntime 1.4 | |||
| if ort_version.startswith('1.4') or ort_version.startswith('1.5'): | |||
There was a problem hiding this comment.
is it true that ort_version >= 1.4 so there is no issue for 1.6 which may be two months later?
wenbingl
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.