Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes nightly build 9/29 #541

Merged
merged 13 commits into from
Sep 30, 2020
Merged

Fixes nightly build 9/29 #541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
2808a7d
Add CastRegressor to cast output predictions into float32 in scikit-l…
xadupre Aug 24, 2020
d8a05a5
Fixes nightly build (#527)
xadupre Aug 28, 2020
64b7aa4
Add complete tutorial to the documentation (#517)
xadupre Sep 3, 2020
c11924b
Upgrade version number to 1.7.1 (#529)
xadupre Sep 3, 2020
54c6327
Checks that issue #197 is fixed.
sdpython May 22, 2020
e354669
Update test_sklearn_tfidf_vectorizer_converter_dataset.py
sdpython May 22, 2020
94ed45d
Update test_sklearn_tfidf_vectorizer_converter_dataset.py
sdpython Sep 1, 2020
3230371
fix ci build
sdpython Sep 18, 2020
0c8d8a3
Checks that issue #197 is fixed.
sdpython May 22, 2020
d593d67
Update test_sklearn_tfidf_vectorizer_converter_dataset.py
sdpython May 22, 2020
62458b6
Update test_sklearn_tfidf_vectorizer_converter_dataset.py
sdpython Sep 1, 2020
b4e84a3
Update test_sklearn_tfidf_vectorizer_converter_pipeline.py
sdpython Sep 24, 2020
0d1c13c
Merge branch 'master' of https://github.com/onnx/sklearn-onnx into ciknn
sdpython Sep 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/test_sklearn_nearest_neighbour_converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,9 @@ def test_model_knn_regressor(self):
@unittest.skipIf(
StrictVersion(onnxruntime.__version__) < StrictVersion("1.2.0"),
reason="not available")
@unittest.skipIf(
StrictVersion(onnx.__version__) <= StrictVersion("1.6.0"),
reason="not available")
def test_model_knn_regressor_radius(self):
model, X = self._fit_model(RadiusNeighborsRegressor())
model_onnx = convert_sklearn(model, "KNN regressor",
Expand Down
4 changes: 2 additions & 2 deletions tests/test_sklearn_tfidf_vectorizer_converter_pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ class TestSklearnTfidfVectorizerPipeline(unittest.TestCase):
def common_test_model_tfidf_vectorizer_pipeline_cls(
self, kind=None, verbose=False):
if kind == 'stop':
if ort_version.startswith('1.4'):
# regression with stopwords in onnxruntime 1.4
if ort_version.startswith('1.4') or ort_version.startswith('1.5'):
Copy link
Member

@wenbingl wenbingl Sep 29, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it true that ort_version >= 1.4 so there is no issue for 1.6 which may be two months later?

# regression with stopwords in onnxruntime 1.4, 1.5
stopwords = ['theh']
else:
stopwords = ['the', 'and', 'is']
Expand Down